Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Unified Diff: chrome/browser/component_updater/component_updater_service.h

Issue 318143003: Make CUS interface more resilient by returning a copy of the data (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/component_updater/component_updater_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/component_updater/component_updater_service.h
diff --git a/chrome/browser/component_updater/component_updater_service.h b/chrome/browser/component_updater/component_updater_service.h
index fe77d4e4927b7ca3f0f76a3e1548b57ffe58b460..2f2fca631c203e8554c9efd5c0cb7ed357f0a065 100644
--- a/chrome/browser/component_updater/component_updater_service.h
+++ b/chrome/browser/component_updater/component_updater_service.h
@@ -207,10 +207,10 @@ class ComponentUpdateService {
virtual ~ComponentUpdateService() {}
private:
- // Returns details about registered component. The object returned is owned
- // by this class. TODO(sorin): replace with a WeakPtr.
- virtual CrxUpdateItem* GetComponentDetails(
- const std::string& component_id) const = 0;
+ // Returns details about registered component in the |item| parameter. The
+ // function returns true in case of success and false in case of errors.
+ virtual bool GetComponentDetails(const std::string& component_id,
+ CrxUpdateItem* item) const = 0;
friend class ::ComponentsUI;
FRIEND_TEST_ALL_PREFIXES(ComponentUpdaterTest, ResourceThrottleLiveNoUpdate);
« no previous file with comments | « no previous file | chrome/browser/component_updater/component_updater_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698