Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 317823009: GN: ui/events/platform target from r270816 (Closed)

Created:
6 years, 6 months ago by jamesr
Modified:
6 years, 6 months ago
Reviewers:
tfarina, brettw, sadrul, sky
CC:
chromium-reviews, tdresser+watch_chromium.org
Visibility:
Public.

Description

GN: ui/events/platform target from r270816 This adds the //ui/events/platform target and adds a dependency from //ui/gl R=sadrul@chromium.org

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -8 lines) Patch
M ui/events/BUILD.gn View 2 chunks +1 line, -8 lines 0 comments Download
A ui/events/platform/BUILD.gn View 1 chunk +30 lines, -0 lines 2 comments Download
M ui/gl/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
jamesr
GN equivalent of https://codereview.chromium.org/284743009
6 years, 6 months ago (2014-06-05 22:09:48 UTC) #1
brettw
lgtm
6 years, 6 months ago (2014-06-05 22:34:56 UTC) #2
sadrul
lgtm
6 years, 6 months ago (2014-06-05 23:37:55 UTC) #3
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 6 months ago (2014-06-05 23:40:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/317823009/1
6 years, 6 months ago (2014-06-05 23:43:01 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-06-06 04:19:24 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 04:23:27 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/72077)
6 years, 6 months ago (2014-06-06 04:23:28 UTC) #8
jamesr
+sky@ to approve ui/
6 years, 6 months ago (2014-06-06 04:26:41 UTC) #9
sky
LGTM
6 years, 6 months ago (2014-06-06 15:49:25 UTC) #10
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 6 months ago (2014-06-06 16:40:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/317823009/1
6 years, 6 months ago (2014-06-06 16:41:15 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 17:55:40 UTC) #13
commit-bot: I haz the power
Could not make sense out of svn commit message.
6 years, 6 months ago (2014-06-06 17:55:41 UTC) #14
jamesr
On 2014/06/06 17:55:41, I haz the power (commit-bot) wrote: > Could not make sense out ...
6 years, 6 months ago (2014-06-06 18:30:15 UTC) #15
tfarina
6 years, 6 months ago (2014-06-07 01:45:30 UTC) #16
Message was sent while issue was closed. 
https://codereview.chromium.org/317823009/diff/1/ui/events/platform/BUILD.gn
File ui/events/platform/BUILD.gn (right):

https://codereview.chromium.org/317823009/diff/1/ui/events/platform/BUILD.gn#...
ui/events/platform/BUILD.gn:5: import("//build/config/ui.gni")
I had this for days in
https://codereview.chromium.org/305293002/diff/100001/ui/events/platform/BUIL...

https://codereview.chromium.org/317823009/diff/1/ui/events/platform/BUILD.gn#...
ui/events/platform/BUILD.gn:8: deps = [
the ordering here is not right. According to
https://code.google.com/p/chromium/wiki/GNStyleGuide#Ordering_within_a_target

it should be:

- sources
- defines
- deps

like I have in mine.

Powered by Google App Engine
This is Rietveld 408576698