Issue 284743009: events: Create a separate platforms target.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 284743009: events: Create a separate platforms target. (Closed)

Created:
6 years, 7 months ago by sadrul

Modified:
6 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tdresser+watch_chromium.org, tfarina, extensions-reviews_chromium.org, Yufeng Shen (Slow to review)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

events: Create a separate platforms target. Split out the platform-event dispatch specific code out of the 'events' target into its own 'events_platform' target, and the x11-specific code into 'x11_events_platform' target. BUG=361137 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270816

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : tot-merge #

Patch Set 7 : . #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+112 lines, -36 lines)			Patch
M	chrome/chrome_browser_chromeos.gypi	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser_extensions.gypi	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	components/bookmarks.gypi	View	1 2 3 4 5	2 chunks	+8 lines, -0 lines	0 comments	Download
M	ui/aura/aura.gyp	View	1 2 3 4 5 6	2 chunks	+2 lines, -0 lines	0 comments	Download
M	ui/base/ui_base.gyp	View	1 2 3 4 5 6	2 chunks	+2 lines, -0 lines	0 comments	Download
M	ui/events/events.gyp	View	1 2 3 4 5 6	4 chunks	+3 lines, -35 lines	0 comments	Download
M	ui/events/ozone/events_ozone.gyp	View	1 2 3 4 5 6	2 chunks	+4 lines, -0 lines	0 comments	Download
A	ui/events/platform/events_platform.gyp	View		1 chunk	+36 lines, -0 lines	0 comments	Download
M	ui/events/platform/platform_event_source.cc	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
A	ui/events/platform/x11/x11_events_platform.gyp	View		1 chunk	+43 lines, -0 lines	0 comments	Download
M	ui/ui_unittests.gyp	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	ui/views/views.gyp	View	1 2 3 4 5 6	4 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sadrul

6 years, 7 months ago (2014-05-15 21:13:27 UTC) #3

Message was sent while issue was closed.

Committed patchset #7 manually as r270816 (presubmit successful).

Expand Messages | Collapse Messages