Issue 317823008: Cast: Add GeneralDescription proto to LogMetadata and populate it when

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 317823008: Cast: Add GeneralDescription proto to LogMetadata and populate it when (Closed)

Created:
6 years, 6 months ago by imcheng

Modified:
6 years, 6 months ago

Reviewers:
Alpha Left Google

CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Cast: Add GeneralDescription proto to LogMetadata and populate it when getting the logs. The current fields (os, product, product version) is populated using chrome_version_info.h. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275526

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -2 lines)			Patch
	M	chrome/renderer/media/cast_session_delegate.cc	View	1	2 chunks	+7 lines, -0 lines	0 comments	Download
	M	media/cast/logging/proto/raw_events.proto	View		2 chunks	+12 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/imcheng@chromium.org/317823008/20001

6 years, 6 months ago (2014-06-06 18:10:41 UTC) #4

Message was sent while issue was closed.

Change committed as 275526

Expand Messages | Collapse Messages