Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2757)

Unified Diff: media/cast/logging/proto/raw_events.proto

Issue 317823008: Cast: Add GeneralDescription proto to LogMetadata and populate it when (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/media/cast_session_delegate.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/cast/logging/proto/raw_events.proto
diff --git a/media/cast/logging/proto/raw_events.proto b/media/cast/logging/proto/raw_events.proto
index e94aed38687b6cfeb11db820f40c772a89771a68..08bf53d19a164f8853624192fb0821fb52f6d296 100644
--- a/media/cast/logging/proto/raw_events.proto
+++ b/media/cast/logging/proto/raw_events.proto
@@ -68,6 +68,14 @@ enum EventType {
PACKET_RECEIVED = 38;
}
+// Contains information independent of the stream that describes the system
+// setup, e.g. OS and hardware info.
+message GeneralDescription {
+ optional string product = 1;
+ optional string product_version = 2;
+ optional string os = 3;
+}
+
// Each log will contain one |LogMetadata|.
message LogMetadata {
// |true| if the events are related to audio. |false| if they are related to
@@ -90,9 +98,11 @@ message LogMetadata {
// to a real time and date.
optional int64 reference_timestamp_ms_at_unix_epoch = 5;
- // Extra data to attach to the log, e.g. system info or
- // experiment tags, in key-value JSON string format.
+ // Extra data to attach to the log, e.g. experiment tags,
+ // in key-value JSON string format. The data is supplied by the application.
optional string extra_data = 6;
+
+ optional GeneralDescription general_description = 7;
}
message AggregatedFrameEvent {
« no previous file with comments | « chrome/renderer/media/cast_session_delegate.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698