Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 317803004: Update nss_revision to r275286. (Closed)

Created:
6 years, 6 months ago by wtc
Modified:
6 years, 6 months ago
Reviewers:
eroman, Ryan Sleevi
CC:
chromium-reviews
Visibility:
Public.

Description

Update nss_revision to r275286. Includes the following CLs: Update to NSS 3.16.2 Beta 3. https://codereview.chromium.org/319593003/ Fix compiler error with -Werror,-Wpointer-sign https://codereview.chromium.org/316353002/ Add the patch file for r275283. https://codereview.chromium.org/317293002/ R=rsleevi@chromium.org BUG=380925 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275484

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 34 (0 generated)
wtc
6 years, 6 months ago (2014-06-05 03:01:37 UTC) #1
Ryan Sleevi
lgtm
6 years, 6 months ago (2014-06-05 03:09:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/317803004/1
6 years, 6 months ago (2014-06-05 03:10:46 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-05 06:49:39 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-05 06:54:50 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel/builds/13724)
6 years, 6 months ago (2014-06-05 06:54:50 UTC) #6
Ryan Sleevi
The CQ bit was checked by rsleevi@chromium.org
6 years, 6 months ago (2014-06-05 23:17:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/317803004/1
6 years, 6 months ago (2014-06-05 23:20:10 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-05 23:33:45 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-05 23:36:10 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel/builds/14132)
6 years, 6 months ago (2014-06-05 23:36:11 UTC) #11
Ryan Sleevi
On 2014/06/05 23:36:11, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 6 months ago (2014-06-05 23:47:37 UTC) #12
wtc
OK, I tested patch set 3 on Mac. This should be good to go.
6 years, 6 months ago (2014-06-06 01:10:30 UTC) #13
eroman
Note that the CL description doesn't match revision number being updated to. Other than that ...
6 years, 6 months ago (2014-06-06 01:14:10 UTC) #14
eroman
Should you change the deps to r275286?
6 years, 6 months ago (2014-06-06 01:17:40 UTC) #15
wtc
On 2014/06/06 01:17:40, eroman wrote: > Should you change the deps to r275286? You are ...
6 years, 6 months ago (2014-06-06 04:13:27 UTC) #16
wtc
The CQ bit was checked by wtc@chromium.org
6 years, 6 months ago (2014-06-06 04:13:56 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/317803004/60001
6 years, 6 months ago (2014-06-06 04:16:01 UTC) #18
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-06 07:51:17 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 07:53:18 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/192700) linux_chromium_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_dbg/builds/32029)
6 years, 6 months ago (2014-06-06 07:53:19 UTC) #21
Ryan Sleevi
The CQ bit was checked by rsleevi@chromium.org
6 years, 6 months ago (2014-06-06 08:19:20 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/317803004/60001
6 years, 6 months ago (2014-06-06 08:20:30 UTC) #23
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-06 08:39:09 UTC) #24
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 08:41:24 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_compile_rel/builds/11429) chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/72110) linux_chromium_chromeos_clang_dbg ...
6 years, 6 months ago (2014-06-06 08:41:25 UTC) #26
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 6 months ago (2014-06-06 12:34:48 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/317803004/60001
6 years, 6 months ago (2014-06-06 12:35:53 UTC) #28
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-06 13:10:29 UTC) #29
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 13:12:37 UTC) #30
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_compile_rel/builds/11462) android_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/192766) chromium_presubmit ...
6 years, 6 months ago (2014-06-06 13:12:38 UTC) #31
wtc
The CQ bit was checked by wtc@chromium.org
6 years, 6 months ago (2014-06-06 15:23:15 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/317803004/80001
6 years, 6 months ago (2014-06-06 15:23:57 UTC) #33
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 18:32:54 UTC) #34
Message was sent while issue was closed.
Change committed as 275484

Powered by Google App Engine
This is Rietveld 408576698