Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: device/hid/hid_report_descriptor.h

Issue 317783010: chrome.hid: enrich model with report IDs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Enrich JavaScript model (no incoming report filter) Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/hid/hid_report_descriptor.h
diff --git a/device/hid/hid_report_descriptor.h b/device/hid/hid_report_descriptor.h
index fa67fa43c291aa033bb648bbf38faeacc0618d80..8907812fbdd0adebc99c132649754ae826dbf015 100644
--- a/device/hid/hid_report_descriptor.h
+++ b/device/hid/hid_report_descriptor.h
@@ -8,8 +8,8 @@
#include <vector>
#include "base/memory/linked_ptr.h"
+#include "device/hid/hid_collection_info.h"
#include "device/hid/hid_report_descriptor_item.h"
-#include "device/hid/hid_usage_and_page.h"
namespace device {
@@ -25,9 +25,13 @@ class HidReportDescriptor {
return items_;
}
- // Returns HID usages of top-level collections present in the descriptor.
+ // Returns top-level collections present in the descriptor,
+ // together with max report sizes
void GetTopLevelCollections(
Ken Rockot(use gerrit already) 2014/06/06 20:04:43 If this is going to return report sizes as well, i
jracle (use Gerrit) 2014/06/07 12:56:21 +1 On 2014/06/06 20:04:43, Ken Rockot wrote:
- std::vector<HidUsageAndPage>* topLevelCollections);
+ std::vector<HidCollectionInfo>* top_level_collections,
+ int* max_input_report_size,
+ int* max_output_report_size,
+ int* max_feature_report_size);
private:
std::vector<linked_ptr<HidReportDescriptorItem> > items_;

Powered by Google App Engine
This is Rietveld 408576698