chrome.hid: enrich model with report IDs

device/hid/hid_report_descriptor.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef DEVICE_HID_HID_REPORT_DESCRIPTOR_H_
 #define DEVICE_HID_HID_REPORT_DESCRIPTOR_H_
 
 #include <vector>
 
 #include "base/memory/linked_ptr.h"
+#include "device/hid/hid_collection_info.h"
 #include "device/hid/hid_report_descriptor_item.h"
-#include "device/hid/hid_usage_and_page.h"
 
 namespace device {
 
 // HID report descriptor.
 // See section 6.2.2 of HID specifications (v1.11).
 class HidReportDescriptor {
 
  public:
   HidReportDescriptor(const uint8_t* bytes, size_t size);
   ~HidReportDescriptor();
 
   const std::vector<linked_ptr<HidReportDescriptorItem> >& items() const {
     return items_;
   }
 
-  // Returns HID usages of top-level collections present in the descriptor.
+  // Returns top-level collections present in the descriptor,
+  // together with max report sizes
   void GetTopLevelCollections(

[Ken Rockot(use gerrit already), 2014/06/06 20:04:43]

If this is going to return report sizes as well, it should be renamed. How about
GetDetails instead of GetTopLevelCollections?

[jracle (use Gerrit), 2014/06/07 12:56:21]

+1

On 2014/06/06 20:04:43, Ken Rockot wrote:

-      std::vector<HidUsageAndPage>* topLevelCollections);
+      std::vector<HidCollectionInfo>* top_level_collections,
+      int* max_input_report_size,
+      int* max_output_report_size,
+      int* max_feature_report_size);
 
  private:
   std::vector<linked_ptr<HidReportDescriptorItem> > items_;
 };
 
 }  // namespace device
 
 #endif  // DEVICE_HID_HID_REPORT_DESCRIPTOR_H_