[Telemetry] Make session restore benchmark not require arguments.

[Telemetry] Make session restore benchmark not require arguments.

Previously, this benchmark required a separate profile generation step as wel
as arguments. This isn't a Telemetric way to write a benchmark. Now, if a
profile isn't given, it generates the correct profile for the benchmark.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275458

[tonyg, 2014-06-04 17:18:25]

Hey Kari,

Since the session restore benchmark will probably be most relevant to your
scheduling work, I thought maybe you could patch in this change (git cl patch
317733002) and then see if it makes running session restore self-explanatory. If
not, I'll try to improve the patch to the point where it's easy.

-Tony

[dtu, 2014-06-04 22:05:00]

lgtm

https://chromiumcodereview.appspot.com/317733002/diff/1/tools/perf/measuremen...
File tools/perf/measurements/session_restore.py (right):

https://chromiumcodereview.appspot.com/317733002/diff/1/tools/perf/measuremen...
tools/perf/measurements/session_restore.py:34: sys.exit(1)
parser.error(message)

[tonyg, 2014-06-05 00:26:53]

The smoke test failed with my previous change that required the options to be
passed to run_benchmark. It was correct that run_benchmark shouldn't require
args. So I updated the session restore benchmark to generate the profile it
needs if not given. PTAL.

[dtu, 2014-06-05 01:35:28]

lgtm

https://chromiumcodereview.appspot.com/317733002/diff/20001/tools/perf/measur...
File tools/perf/measurements/session_restore.py (right):

https://chromiumcodereview.appspot.com/317733002/diff/20001/tools/perf/measur...
tools/perf/measurements/session_restore.py:33: if not options.profile_dir:
Goes into ProcessCommandLineArgs still

[tonyg, 2014-06-05 02:00:05]

The CQ bit was checked by tonyg@chromium.org

[commit-bot: I haz the power, 2014-06-05 02:02:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tonyg@chromium.org/317733002/40001

[tonyg, 2014-06-05 04:10:14]

The CQ bit was checked by tonyg@chromium.org

[commit-bot: I haz the power, 2014-06-05 04:12:33]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tonyg@chromium.org/317733002/60001

[commit-bot: I haz the power, 2014-06-05 07:22:18]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-06-05 07:36:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-05 07:36:38]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)

[jeremy, 2014-06-05 10:47:26]

https://codereview.chromium.org/317733002/diff/60001/tools/perf/benchmarks/se...
File tools/perf/benchmarks/session_restore.py (right):

https://codereview.chromium.org/317733002/diff/60001/tools/perf/benchmarks/se...
tools/perf/benchmarks/session_restore.py:15: class
_SessionRestoreTest(test.Test):
I worry that a mistake in the bot config could make us silently run all tests
with a small profile generated on each run on the build slaves.

Should there be a yes/no prompt when Telemetry is smart about generating the
profile for you?

[tonyg, 2014-06-05 16:41:15]

The CQ bit was checked by tonyg@chromium.org

[commit-bot: I haz the power, 2014-06-05 16:46:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tonyg@chromium.org/317733002/80001

[tonyg, 2014-06-05 17:01:11]

The CQ bit was checked by tonyg@chromium.org

[commit-bot: I haz the power, 2014-06-05 17:03:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tonyg@chromium.org/317733002/100001

[tonyg, 2014-06-05 22:43:58]

The CQ bit was checked by tonyg@chromium.org

[commit-bot: I haz the power, 2014-06-05 22:44:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tonyg@chromium.org/317733002/160001

[tonyg, 2014-06-06 02:12:15]

The CQ bit was checked by tonyg@chromium.org

[commit-bot: I haz the power, 2014-06-06 02:14:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tonyg@chromium.org/317733002/180001

[tonyg, 2014-06-06 03:40:00]

The CQ bit was checked by tonyg@chromium.org

[commit-bot: I haz the power, 2014-06-06 03:40:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tonyg@chromium.org/317733002/200001

[commit-bot: I haz the power, 2014-06-06 07:08:39]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-06-06 08:32:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-06 08:32:53]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[tonyg, 2014-06-06 13:33:07]

The win bots were hitting a NOTREACHED(). Fixed in
https://codereview.chromium.org/317163006/ . Trying CQ again.

[tonyg, 2014-06-06 13:35:39]

The CQ bit was checked by tonyg@chromium.org

[commit-bot: I haz the power, 2014-06-06 13:37:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tonyg@chromium.org/317733002/220001

[commit-bot: I haz the power, 2014-06-06 16:36:57]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)

[commit-bot: I haz the power, 2014-06-06 16:46:05]

Change committed as 275458