Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Unified Diff: tools/telemetry/telemetry/core/browser_options.py

Issue 317733002: [Telemetry] Make session restore benchmark not require arguments. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/benchmarks/session_restore_with_url.py ('k') | tools/telemetry/telemetry/test_runner.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/browser_options.py
diff --git a/tools/telemetry/telemetry/core/browser_options.py b/tools/telemetry/telemetry/core/browser_options.py
index 955fe250f032b8703ef2e6759273013573601ed8..1a4514093e9cebeb66842e4137e810d284426a89 100644
--- a/tools/telemetry/telemetry/core/browser_options.py
+++ b/tools/telemetry/telemetry/core/browser_options.py
@@ -308,12 +308,17 @@ class BrowserOptions(object):
self.dont_override_profile = True
if self.profile_dir and self.profile_type != 'clean':
- raise Exception("It's illegal to specify both --profile-type and"
- " --profile-dir.")
+ logging.critical(
+ "It's illegal to specify both --profile-type and --profile-dir.\n"
+ "For more information see: http://goo.gl/ngdGD5")
+ sys.exit(1)
if self.profile_dir and not os.path.isdir(self.profile_dir):
- raise Exception("Directory specified by --profile-dir (%s) doesn't"
- " exist or isn't a directory." % (self.profile_dir))
+ logging.critical(
+ "Directory specified by --profile-dir (%s) doesn't exist "
+ "or isn't a directory.\n"
+ "For more information see: http://goo.gl/ngdGD5" % self.profile_dir)
+ sys.exit(1)
if not self.profile_dir:
self.profile_dir = profile_types.GetProfileDir(self.profile_type)
« no previous file with comments | « tools/perf/benchmarks/session_restore_with_url.py ('k') | tools/telemetry/telemetry/test_runner.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698