Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: tests/language/number_identity2_test.dart

Issue 317643004: Unify handling of identical(NaN, NaN) between generated code and Dart API. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/object_test.cc ('K') | « runtime/vm/object_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/language/number_identity2_test.dart
===================================================================
--- tests/language/number_identity2_test.dart (revision 37108)
+++ tests/language/number_identity2_test.dart (working copy)
@@ -8,14 +8,31 @@
// VMOptions=--optimization-counter-threshold=10
import "package:expect/expect.dart";
+import 'dart:typed_data';
-main() {
- for (int i = 0; i < 20; i++) testNumberIdentity();
+double uint64toDouble(int i) {
+ var buffer = new Uint8List(8).buffer;
+ var bdata = new ByteData.view(buffer);
+ bdata.setUint64(0, i);
+ return bdata.getFloat64(0);
}
-
testNumberIdentity () {
var a = double.NAN;
var b = a + 0.0;
Expect.isTrue(identical(a, b));
+
+ a = uint64toDouble((1 << 64) - 1);
+ b = uint64toDouble((1 << 64) - 2);
+ Expect.isFalse(identical(a, b));
+
+ a = 0.0/0.0;
+ b = 1.0/0.0;
+ Expect.isFalse(identical(a, b));
}
+
+main() {
+ for (int i = 0; i < 20; i++) {
+ testNumberIdentity();
+ }
+}
« runtime/vm/object_test.cc ('K') | « runtime/vm/object_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698