Unify handling of identical(NaN, NaN) between generated code and Dart API.

runtime/vm/object_test.cc

Index: runtime/vm/object_test.cc
===================================================================
--- runtime/vm/object_test.cc	(revision 37108)
+++ runtime/vm/object_test.cc	(working copy)
@@ -524,10 +524,26 @@
     EXPECT(!dbl1.OperatorEquals(Smi::Handle(Smi::New(3))));
     EXPECT(!dbl1.OperatorEquals(Double::Handle()));
     const Double& nan0 = Double::Handle(Double::New(NAN));
+    EXPECT(isnan(nan0.value()));
     EXPECT(nan0.IsIdenticalTo(nan0));
     EXPECT(nan0.CanonicalizeEquals(nan0));
     EXPECT(!nan0.OperatorEquals(nan0));
-    // TODO(18738): Test bitwise different NaNs after agreement on spec.
+    const Double& nan1 = Double::Handle(Double::New(0.0/0.0));
+    const Double& nan2 = Double::Handle(Double::New(1.0/0.0));

[koda, 2014/06/06 23:54:28]

Please rename the variable to something more appropriate, like 'inf'.

[regis, 2014/06/09 16:37:21]

Done.

+    EXPECT(isnan(nan1.value()));
+    EXPECT(!isnan(nan2.value()));
+    EXPECT(!nan1.IsIdenticalTo(nan2));
+    EXPECT(!nan1.CanonicalizeEquals(nan2));
+    EXPECT(!nan1.OperatorEquals(nan2));
+    const Double& nan3 = Double::Handle(
+        Double::New(bit_cast<double>(kMaxUint64 - 0)));
+    const Double& nan4 = Double::Handle(
+        Double::New(bit_cast<double>(kMaxUint64 - 1)));
+    EXPECT(isnan(nan3.value()));
+    EXPECT(isnan(nan4.value()));
+    EXPECT(!nan3.IsIdenticalTo(nan4));
+    EXPECT(!nan3.CanonicalizeEquals(nan4));
+    EXPECT(!nan3.OperatorEquals(nan4));
   }
   {
     const String& dbl_str0 = String::Handle(String::New("bla"));