Issue 317633003: Revert "Support external startup data in V8."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 317633003: Revert "Support external startup data in V8." (Closed)

Created:
6 years, 6 months ago by mvstanton

Modified:
6 years, 6 months ago

Reviewers:

CC:
v8-dev, Paweł Hajdan Jr.

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Revert "Support external startup data in V8." This reverts commit r21646, as it blocks pushing to chromium. TBR=vogelheim@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21666

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+236 lines, -1044 lines)			Patch
M	BUILD.gn	View	4 chunks	+1 line, -9 lines	0 comments	Download
M	build/features.gypi	View	2 chunks	+3 lines, -8 lines	0 comments	Download
M	include/v8.h	View	1 chunk	+0 lines, -18 lines	0 comments	Download
M	src/api.cc	View	2 chunks	+2 lines, -18 lines	0 comments	Download
M	src/d8.h	View	2 chunks	+1 line, -5 lines	0 comments	Download
M	src/d8.cc	View	2 chunks	+0 lines, -65 lines	0 comments	Download
M	src/flag-definitions.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/heap.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/mksnapshot.cc	View	5 chunks	+12 lines, -59 lines	0 comments	Download
M	src/natives.h	View	2 chunks	+0 lines, -9 lines	0 comments	Download
D	src/natives-external.cc	View	1 chunk	+0 lines, -190 lines	0 comments	Download
M	src/serialize.h	View	4 chunks	+75 lines, -3 lines	0 comments	Download
M	src/serialize.cc	View	3 chunks	+21 lines, -1 line	0 comments	Download
M	src/snapshot.h	View	2 chunks	+10 lines, -7 lines	0 comments	Download
M	src/snapshot-common.cc	View	3 chunks	+52 lines, -13 lines	0 comments	Download
D	src/snapshot-external.cc	View	1 chunk	+0 lines, -140 lines	0 comments	Download
D	src/snapshot-source-sink.h	View	1 chunk	+0 lines, -88 lines	0 comments	Download
D	src/snapshot-source-sink.cc	View	1 chunk	+0 lines, -95 lines	0 comments	Download
M	test/cctest/test-serialize.cc	View	3 chunks	+39 lines, -56 lines	0 comments	Download
D	tools/concatenate-files.py	View	1 chunk	+0 lines, -75 lines	0 comments	Download
M	tools/gyp/v8.gyp	View	10 chunks	+7 lines, -130 lines	0 comments	Download
M	tools/js2c.py	View	8 chunks	+10 lines, -52 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

mvstanton

6 years, 6 months ago (2014-06-04 08:36:01 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r21666 (tree was closed).

Expand Messages | Collapse Messages