Translate: Bug fix: need to normalize the language code for Translate UI

chrome/browser/translate/translate_tab_helper.cc

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/translate/translate_tab_helper.h"
 
 #include <vector>
 
 #include "base/logging.h"
 #include "base/prefs/pref_service.h"
@@ skipping 105 matching lines @@
     std::string* source,
     std::string* target) {
   DCHECK(source != NULL);
   DCHECK(target != NULL);
 
   TranslateTabHelper* translate_tab_helper = FromWebContents(web_contents);
   if (!translate_tab_helper)
     return;
 
   *source = translate_tab_helper->GetLanguageState().original_language();
+  *source = TranslateDownloadManager::GetLanguageCode(*source);

[Takashi Toyoshima, 2014/06/04 20:39:33]

Optional suggestion.

If you want to store the temporary result of
GetLanguageState().original_language(), it might be better to use another
variable with a meaningful name.
Or, just like
*source = TranslateDownloadManager::GetLanguageCode(
    translate_tab_helper->GetLanguageState().original_language());

But, it may be just my preference. So it's up to you.

[hajimehoshi, 2014/06/05 08:42:53]

Done.

 
   Profile* profile =
       Profile::FromBrowserContext(web_contents->GetBrowserContext());
   Profile* original_profile = profile->GetOriginalProfile();
   PrefService* prefs = original_profile->GetPrefs();
   scoped_ptr<TranslatePrefs> translate_prefs = CreateTranslatePrefs(prefs);
   if (!web_contents->GetBrowserContext()->IsOffTheRecord()) {
     std::string auto_translate_language =
         TranslateManager::GetAutoTargetLanguage(*source, translate_prefs.get());
     if (!auto_translate_language.empty()) {
@@ skipping 397 matching lines @@
     if (GetLanguageState().InTranslateNavigation())
       return;
   }
 
   TranslateBubbleFactory::Show(
       browser->window(), web_contents(), step, error_type);
 #else
   NOTREACHED();
 #endif
 }