Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 317583004: GN: blink_platform test targets (Closed)

Created:
6 years, 6 months ago by jamesr
Modified:
6 years, 6 months ago
Reviewers:
brettw
CC:
blink-reviews, awong, Nico
Visibility:
Public.

Description

GN: blink_platform test targets Adds the blink_heap_unittests and blink_platform_unittests target, bringing Source/platform/BUILD.gn to parity with Source/platform/blink_platform_tests.gyp. These fail to link on mac with missing symbols in libjpeg_turbo due to a missing yasm target but should otherwise be functional. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175447

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -0 lines) Patch
M Source/platform/BUILD.gn View 1 2 chunks +97 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jamesr
6 years, 6 months ago (2014-06-04 04:53:17 UTC) #1
brettw
lgtm https://codereview.chromium.org/317583004/diff/1/Source/platform/BUILD.gn File Source/platform/BUILD.gn (right): https://codereview.chromium.org/317583004/diff/1/Source/platform/BUILD.gn#newcode18 Source/platform/BUILD.gn:18: [ "blink_heap.gypi" ]) This should match the other ...
6 years, 6 months ago (2014-06-04 05:01:15 UTC) #2
jamesr
https://codereview.chromium.org/317583004/diff/1/Source/platform/BUILD.gn File Source/platform/BUILD.gn (right): https://codereview.chromium.org/317583004/diff/1/Source/platform/BUILD.gn#newcode18 Source/platform/BUILD.gn:18: [ "blink_heap.gypi" ]) On 2014/06/04 05:01:15, brettw wrote: > ...
6 years, 6 months ago (2014-06-04 05:27:00 UTC) #3
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 6 months ago (2014-06-04 05:29:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/317583004/20001
6 years, 6 months ago (2014-06-04 05:29:20 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 06:47:47 UTC) #6
Message was sent while issue was closed.
Change committed as 175447

Powered by Google App Engine
This is Rietveld 408576698