Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1108)

Unified Diff: Source/core/loader/FrameLoader.cpp

Issue 317513002: Add a RefPtr<Frame> for child in FrameLoader::checkLoadCompleteForThisFrame (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: +test Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/http/tests/misc/resources/detached-frame.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/loader/FrameLoader.cpp
diff --git a/Source/core/loader/FrameLoader.cpp b/Source/core/loader/FrameLoader.cpp
index 8147af34e14c1077d603442f6fea78bacb2dd1b5..155c93fe947416aa6b03d7fdf6d826df77cbe693 100644
--- a/Source/core/loader/FrameLoader.cpp
+++ b/Source/core/loader/FrameLoader.cpp
@@ -948,9 +948,9 @@ bool FrameLoader::checkLoadCompleteForThisFrame()
RefPtr<LocalFrame> protect(m_frame);
bool allChildrenAreDoneLoading = true;
- for (Frame* child = m_frame->tree().firstChild(); child; child = child->tree().nextSibling()) {
+ for (RefPtr<Frame> child = m_frame->tree().firstChild(); child; child = child->tree().nextSibling()) {
if (child->isLocalFrame())
- allChildrenAreDoneLoading &= toLocalFrame(child)->loader().checkLoadCompleteForThisFrame();
+ allChildrenAreDoneLoading &= toLocalFrame(child.get())->loader().checkLoadCompleteForThisFrame();
}
if (m_state == FrameStateProvisional && m_provisionalDocumentLoader) {
« no previous file with comments | « LayoutTests/http/tests/misc/resources/detached-frame.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698