LayoutTests/http/tests/misc/resources/detached-frame.html - Issue 317513002: Add a RefPtr<Frame> for child in FrameLoader::checkLoadCompleteForThisFrame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/misc/resources/detached-frame.html

Issue 317513002: Add a RefPtr<Frame> for child in FrameLoader::checkLoadCompleteForThisFrame (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: +test Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: LayoutTests/http/tests/misc/resources/detached-frame.html

diff --git a/LayoutTests/http/tests/xmlhttprequest/resources/detached-frame.html b/LayoutTests/http/tests/misc/resources/detached-frame.html

similarity index 50%

copy from LayoutTests/http/tests/xmlhttprequest/resources/detached-frame.html

copy to LayoutTests/http/tests/misc/resources/detached-frame.html

index ff37a5529b478ec3a1b93a2bc4683b21db765440..43459c272ac900c64d1ab5c91eb379000bd7a8ee 100644

--- a/LayoutTests/http/tests/xmlhttprequest/resources/detached-frame.html

+++ b/LayoutTests/http/tests/misc/resources/detached-frame.html

@@ -1,21 +1,15 @@

-<head>

function test() {

var xhr = new XMLHttpRequest;

xhr.open("GET", "detached-frame.html");

xhr.send();

- window.parent.childDocument = document; // GC protect

xhr.onreadystatechange = function() {

if (xhr.readyState == xhr.DONE) {

var parentWindow = window.parent;

- parentWindow.document.body.removeChild(parentWindow.document.getElementsByTagName("iframe")[0]);

- parentWindow.document.body.innerHTML += "<p>PASS: No crash.</p>";

- if (parentWindow.testRunner)

+ parentWindow.document.body.innerHTML += "";

parentWindow.testRunner.notifyDone();

}

</script>

-</head>

-<body onload="test()">

-</body>

+<body onload="test()">

« no previous file with comments | « LayoutTests/http/tests/misc/detach-during-notifyDone-expected.txt ('k') | Source/core/loader/FrameLoader.cpp » ('j') | no next file with comments »