sync: cut a few profile deps from DataTypeControllers.

sync: cut a few profile deps from DataTypeControllers.

- UserShare: previously the DTC would query PSS::GetUserShare whenever it decided it needed it, implicitly abiding by the rule that GetUserShare shall not be called until backend initialization is complete (implicit because the DTC knows nothing about backend init in theory, but we had carefully ordered things to work). Instead, we now pass it deterministically as soon as the share becomes available via an explicit call to the DTC (which the PSS already tracks).

- DeactivateDataType: Changes the precondition to DTC::Stop such that it expects the backend has already been informed to stop routing changes for its type. The Deactivate call can be done safely up front by the DataTypeManager (which also handles ActivateDataType).

- Profile: [Non]UIDataTypeController doesn't need a profile, so push that dep down to the subclasses in browser/ that require it.

- ProfileSyncComponentsFactory: the DTCs should now be able to use SyncApiComponentFactory interface exclusively.

Also rename ModelAssociationResultProcessor -> ModelAssociationManagerDelegate.

BUG=339726
R=haitaol@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275935

[tim (not reviewing), 2014-06-05 17:35:17]

On 2014/06/04 17:38:03, timsteele wrote:

I somehow had the UIDataTypeController changes mixed up into another branch. 
They should all be here now.

[haitaol1, 2014-06-05 22:07:04]

https://codereview.chromium.org/317453002/diff/80001/chrome/browser/sync/prof...
File chrome/browser/sync/profile_sync_service.cc (right):

https://codereview.chromium.org/317453002/diff/80001/chrome/browser/sync/prof...
chrome/browser/sync/profile_sync_service.cc:1018: for
(DataTypeController::TypeMap::iterator it =
This should be called at the beginning to set user share in backup/rollback
mode, too.

[tim (not reviewing), 2014-06-06 18:52:54]

https://codereview.chromium.org/317453002/diff/80001/chrome/browser/sync/prof...
File chrome/browser/sync/profile_sync_service.cc (right):

https://codereview.chromium.org/317453002/diff/80001/chrome/browser/sync/prof...
chrome/browser/sync/profile_sync_service.cc:1018: for
(DataTypeController::TypeMap::iterator it =
On 2014/06/05 22:07:04, haitaol1 wrote:
> This should be called at the beginning to set user share in backup/rollback
> mode, too.

Uh oh! Good catch. Are there backup/restore tests that tickle the DTCs?  Ideally
this would get caught by a test.

Should the debugging stuff happen before as well?

[haitaol1, 2014-06-06 20:44:34]

https://codereview.chromium.org/317453002/diff/80001/chrome/browser/sync/prof...
File chrome/browser/sync/profile_sync_service.cc (right):

https://codereview.chromium.org/317453002/diff/80001/chrome/browser/sync/prof...
chrome/browser/sync/profile_sync_service.cc:1018: for
(DataTypeController::TypeMap::iterator it =
On 2014/06/06 18:52:53, timsteele wrote:
> On 2014/06/05 22:07:04, haitaol1 wrote:
> > This should be called at the beginning to set user share in backup/rollback
> > mode, too.
> 
> Uh oh! Good catch. Are there backup/restore tests that tickle the DTCs? 
Ideally
> this would get caught by a test.

The integration test I'm submitting should be able to catch this. Other stuff is
probably not needed in backup/rollback mode.

> 
> Should the debugging stuff happen before as well?

[haitaol1, 2014-06-09 15:40:56]

lgtm

[tim (not reviewing), 2014-06-09 17:19:28]

The CQ bit was checked by tim@chromium.org

[commit-bot: I haz the power, 2014-06-09 17:21:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tim@chromium.org/317453002/120001

[tim (not reviewing), 2014-06-10 04:02:30]

Committed patchset #6 manually as r275935 (presubmit successful).