sync: cut a few profile deps from DataTypeControllers.

chrome/browser/sync/profile_sync_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/profile_sync_service.h"
 
 #include <cstddef>
 #include <map>
 #include <set>
 #include <utility>
@@ skipping 995 matching lines @@
     UpdateLastSyncedTime();
   }
 
   if (startup_controller_.auto_start_enabled() && !FirstSetupInProgress()) {
     // Backend is initialized but we're not in sync setup, so this must be an
     // autostart - mark our sync setup as completed and we'll start syncing
     // below.
     SetSyncSetupCompleted();
   }
 
+  // Give the DataTypeControllers a handle to the now initialized backend
+  // as a UserShare.
+  for (DataTypeController::TypeMap::iterator it =

[haitaol1, 2014/06/05 22:07:04]

This should be called at the beginning to set user share in backup/rollback
mode, too.

[tim (not reviewing), 2014/06/06 18:52:53]

Uh oh! Good catch. Are there backup/restore tests that tickle the DTCs?  Ideally
this would get caught by a test.

Should the debugging stuff happen before as well?

[haitaol1, 2014/06/06 20:44:33]

The integration test I'm submitting should be able to catch this. Other stuff is
probably not needed in backup/rollback mode.

+       directory_data_type_controllers_.begin();
+       it != directory_data_type_controllers_.end(); ++it) {
+    it->second->OnUserShareReady(GetUserShare());
+  }
+
   // Check HasSyncSetupCompleted() before NotifyObservers() to avoid spurious
   // data type configuration because observer may flag setup as complete and
   // trigger data type configuration.
   if (HasSyncSetupCompleted()) {
     ConfigureDataTypeManager();
   } else {
     DCHECK(FirstSetupInProgress());
   }
 
   NotifyObservers();
@@ skipping 1442 matching lines @@
   network_resources_ = network_resources.Pass();
 }
 
 bool ProfileSyncService::HasSyncingBackend() const {
   return backend_mode_ != SYNC ? false : backend_ != NULL;
 }
 
 void ProfileSyncService::SetBackupStartDelayForTest(base::TimeDelta delay) {
   backup_start_delay_ = delay;
 }