Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 317433004: Get view manager client lib unit test harness to run again. Does not get any individual tests worki… (Closed)

Created:
6 years, 6 months ago by Ben Goodger (Google)
Modified:
6 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Get view manager client lib unit test harness to run again. Does not get any individual tests working R=sky@chromium.org http://crbug.com/365012 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274618

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 2

Patch Set 4 : . #

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -22 lines) Patch
M mojo/examples/embedded_app/embedded_app.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/window_manager/window_manager.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager.cc View 1 2 3 3 chunks +40 lines, -7 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_private.h View 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.cc View 1 chunk +3 lines, -5 lines 0 comments Download
A mojo/services/public/cpp/view_manager/tests/DEPS View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc View 1 2 3 5 chunks +69 lines, -0 lines 0 comments Download
M mojo/services/public/cpp/view_manager/view_manager.h View 3 chunks +14 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ben Goodger (Google)
6 years, 6 months ago (2014-06-03 19:43:53 UTC) #1
sky
LGTM https://codereview.chromium.org/317433004/diff/40001/mojo/services/public/cpp/view_manager/lib/view_manager.cc File mojo/services/public/cpp/view_manager/lib/view_manager.cc (right): https://codereview.chromium.org/317433004/diff/40001/mojo/services/public/cpp/view_manager/lib/view_manager.cc#newcode62 mojo/services/public/cpp/view_manager/lib/view_manager.cc:62: nit: only one newline. https://codereview.chromium.org/317433004/diff/40001/mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc File mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc (right): ...
6 years, 6 months ago (2014-06-03 20:15:27 UTC) #2
Ben Goodger (Google)
6 years, 6 months ago (2014-06-03 21:02:16 UTC) #3
Message was sent while issue was closed.
Committed patchset #5 manually as r274618 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698