Get view manager client lib unit test harness to run again. Does not get any individual tests worki…

mojo/services/public/cpp/view_manager/lib/view_manager.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mojo/services/public/cpp/view_manager/view_manager.h"
 
-#include "base/message_loop/message_loop.h"
+#include "base/bind.h"
+#include "base/run_loop.h"
 #include "mojo/public/cpp/application/application.h"
+#include "mojo/services/public/cpp/view_manager/lib/view_manager_private.h"
 #include "mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.h"
 #include "mojo/services/public/cpp/view_manager/lib/view_tree_node_private.h"
 #include "mojo/services/public/cpp/view_manager/view.h"
 
 namespace mojo {
 namespace view_manager {
+namespace {
 
-ViewManager::ViewManager(Application* application)
-    : synchronizer_(NULL),
-      tree_(NULL) {
-  application->AddService<ViewManagerSynchronizer>(this);
-  // Block in a nested message loop until the ViewManagerSynchronizer is set up.
-  base::MessageLoop::current()->Run();
+void OnViewManagerReady(base::RunLoop* loop, ViewManager* manager) {
+  loop->Quit();
 }
 
+}  // namespace
+
+////////////////////////////////////////////////////////////////////////////////
+// ViewManager, public:
+
 ViewManager::~ViewManager() {
   while (!nodes_.empty()) {
     IdToNodeMap::iterator it = nodes_.begin();
     if (synchronizer_->OwnsNode(it->second->id()))
       it->second->Destroy();
     else
       nodes_.erase(it);
   }
   while (!views_.empty()) {
     IdToViewMap::iterator it = views_.begin();
     if (synchronizer_->OwnsView(it->second->id()))
       it->second->Destroy();
     else
       views_.erase(it);
   }
 }
 
+// static
+ViewManager* ViewManager::CreateBlocking(Application* application) {
+  base::RunLoop init_loop;
+  ViewManager* manager = new ViewManager(
+      application,
+      base::Bind(&OnViewManagerReady, &init_loop));
+  init_loop.Run();
+  return manager;
+}
+
+// static
+void ViewManager::Create(
+    Application* application,
+    const base::Callback<void(ViewManager*)> ready_callback) {
+  new ViewManager(application, ready_callback);
+}
+
+

[sky, 2014/06/03 20:15:26]

nit: only one newline.

 ViewTreeNode* ViewManager::GetNodeById(TransportNodeId id) {
   IdToNodeMap::const_iterator it = nodes_.find(id);
   return it != nodes_.end() ? it->second : NULL;
 }
 
 View* ViewManager::GetViewById(TransportViewId id) {
   IdToViewMap::const_iterator it = views_.find(id);
   return it != views_.end() ? it->second : NULL;
 }
 
 void ViewManager::Embed(const String& url, ViewTreeNode* node) {
   synchronizer_->Embed(url, node->id());
 }
 
+////////////////////////////////////////////////////////////////////////////////
+// ViewManager, private:
+
+ViewManager::ViewManager(
+    Application* application,
+    const base::Callback<void(ViewManager*)> ready_callback)
+    : ready_callback_(ready_callback),
+      synchronizer_(NULL),
+      tree_(NULL) {
+  application->AddService<ViewManagerSynchronizer>(this);
+}
+
 }  // namespace view_manager
 }  // namespace mojo