Move MIDI code to hang off WebFrame.

Move MIDI code to hang off WebFrame.

BUG=304341
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175803

[jam, 2014-06-06 18:23:52]

https://codereview.chromium.org/317413003/diff/1/Source/modules/webmidi/MIDIC...
File Source/modules/webmidi/MIDIController.h (right):

https://codereview.chromium.org/317413003/diff/1/Source/modules/webmidi/MIDIC...
Source/modules/webmidi/MIDIController.h:42: class MIDIController FINAL : public
NoBaseWillBeGarbageCollectedFinalized<MIDIController>, public
WillBeHeapSupplement<LocalFrame> {
not sure if I need to remove all the oilpan stuff in this class because
LocalFrame isn't using oilpan while Page is?

[sof, 2014-06-06 19:32:55]

https://codereview.chromium.org/317413003/diff/1/Source/modules/webmidi/MIDIC...
File Source/modules/webmidi/MIDIController.h (right):

https://codereview.chromium.org/317413003/diff/1/Source/modules/webmidi/MIDIC...
Source/modules/webmidi/MIDIController.h:42: class MIDIController FINAL : public
NoBaseWillBeGarbageCollectedFinalized<MIDIController>, public
WillBeHeapSupplement<LocalFrame> {
On 2014/06/06 18:23:52, jam wrote:
> not sure if I need to remove all the oilpan stuff in this class because
> LocalFrame isn't using oilpan while Page is?

That's right (for now.) Consequently, simplify this to:

   class MIDIController FINAL : public Supplement<LocalFrame> { ... }

https://codereview.chromium.org/317413003/diff/1/Source/modules/webmidi/MIDIC...
Source/modules/webmidi/MIDIController.h:52: static MIDIController*
from(LocalFrame* frame) { return
static_cast<MIDIController*>(WillBeHeapSupplement<LocalFrame>::from(frame,
supplementName())); }
s/WillBeHeapSupplement/Supplement/

https://codereview.chromium.org/317413003/diff/1/Source/modules/webmidi/MIDIC...
Source/modules/webmidi/MIDIController.h:54: virtual void trace(Visitor* visitor)
OVERRIDE { WillBeHeapSupplement<LocalFrame>::trace(visitor); }
You can remove this trace() OVERRIDE.

[jam, 2014-06-06 20:03:27]

all done, thanks for looking. I also removed some other stuff that was added
recently.

[sof, 2014-06-06 20:13:03]

https://codereview.chromium.org/317413003/diff/20001/Source/modules/webmidi/M...
File Source/modules/webmidi/MIDIController.h (right):

https://codereview.chromium.org/317413003/diff/20001/Source/modules/webmidi/M...
Source/modules/webmidi/MIDIController.h:46: void
requestSysexPermission(PassRefPtr<MIDIAccess>);
Why this change? MIDIAccess is still a GCed object with Oilpan enabled, right?

[jam, 2014-06-06 20:38:29]

https://codereview.chromium.org/317413003/diff/20001/Source/modules/webmidi/M...
File Source/modules/webmidi/MIDIController.h (right):

https://codereview.chromium.org/317413003/diff/20001/Source/modules/webmidi/M...
Source/modules/webmidi/MIDIController.h:46: void
requestSysexPermission(PassRefPtr<MIDIAccess>);
On 2014/06/06 20:13:03, sof wrote:
> Why this change? MIDIAccess is still a GCed object with Oilpan enabled, right?

oh, I misunderstood and thought that it should be undone. i undid that change
now.

[sof, 2014-06-06 20:44:03]

On 2014/06/06 20:38:29, jam wrote:
>
https://codereview.chromium.org/317413003/diff/20001/Source/modules/webmidi/M...
> File Source/modules/webmidi/MIDIController.h (right):
> 
>
https://codereview.chromium.org/317413003/diff/20001/Source/modules/webmidi/M...
> Source/modules/webmidi/MIDIController.h:46: void
> requestSysexPermission(PassRefPtr<MIDIAccess>);
> On 2014/06/06 20:13:03, sof wrote:
> > Why this change? MIDIAccess is still a GCed object with Oilpan enabled,
right?
> 
> oh, I misunderstood and thought that it should be undone. i undid that change
> now.

thanks, lgtm (oilpan related changes)

[haraken, 2014-06-07 02:38:45]

LGTM.

What other modules you're planning to move off from Page?

[kouhei (in TOK), 2014-06-09 01:57:30]

+toyoshim

lgtm

[Takashi Toyoshima, 2014-06-09 04:50:31]

lgtm

[jam, 2014-06-09 06:09:07]

On 2014/06/07 02:38:45, haraken wrote:
> LGTM.
> 
> What other modules you're planning to move off from Page?

all the provideFooTo calls in
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...,
i.e.
MediaKeys, SpeechRecognition, NavigatorContentUtils, DatabaseClient,
StorageQuotaClient, WorkerGlobalScopeProxy, Push, ScreenOrientation

[jam, 2014-06-09 06:09:12]

The CQ bit was checked by jam@chromium.org

[jam, 2014-06-09 06:09:44]

The CQ bit was unchecked by jam@chromium.org

[jam, 2014-06-09 06:31:01]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2014-06-09 06:31:37]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jam@chromium.org/317413003/40001

[commit-bot: I haz the power, 2014-06-09 06:49:33]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/7268)
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/10789)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/11234)

[commit-bot: I haz the power, 2014-06-09 06:53:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-09 06:53:31]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/7270)

[tkent, 2014-06-09 07:56:14]

web/ lgtm.

Please fix the webkit_unit_tests crash.

[jam, 2014-06-09 16:15:14]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2014-06-09 16:15:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jam@chromium.org/317413003/60001

[commit-bot: I haz the power, 2014-06-09 17:23:00]

Change committed as 175803