Move MIDI code to hang off WebFrame.

Source/modules/webmidi/MIDIController.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 13 matching lines @@
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef MIDIController_h
 #define MIDIController_h
 
-#include "core/page/Page.h"
+#include "core/frame/LocalFrame.h"
 #include "platform/heap/Handle.h"
 
 namespace WebCore {
 
 class MIDIAccess;
 class MIDIClient;
 
-class MIDIController FINAL : public NoBaseWillBeGarbageCollectedFinalized<MIDIController>, public WillBeHeapSupplement<Page> {
+class MIDIController FINAL : public NoBaseWillBeGarbageCollectedFinalized<MIDIController>, public WillBeHeapSupplement<LocalFrame> {

[jam, 2014/06/06 18:23:52]

not sure if I need to remove all the oilpan stuff in this class because
LocalFrame isn't using oilpan while Page is?

[sof, 2014/06/06 19:32:55]

That's right (for now.) Consequently, simplify this to:

   class MIDIController FINAL : public Supplement<LocalFrame> { ... }

     WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(MIDIController);
 public:
     virtual ~MIDIController();
 
     void requestSysexPermission(PassRefPtrWillBeRawPtr<MIDIAccess>);
     void cancelSysexPermissionRequest(MIDIAccess*);
 
     static PassOwnPtrWillBeRawPtr<MIDIController> create(PassOwnPtr<MIDIClient>);
     static const char* supplementName();
-    static MIDIController* from(Page* page) { return static_cast<MIDIController*>(WillBeHeapSupplement<Page>::from(page, supplementName())); }
+    static MIDIController* from(LocalFrame* frame) { return static_cast<MIDIController*>(WillBeHeapSupplement<LocalFrame>::from(frame, supplementName())); }

[sof, 2014/06/06 19:32:55]

s/WillBeHeapSupplement/Supplement/

 
-    virtual void trace(Visitor* visitor) OVERRIDE { WillBeHeapSupplement<Page>::trace(visitor); }
+    virtual void trace(Visitor* visitor) OVERRIDE { WillBeHeapSupplement<LocalFrame>::trace(visitor); }

[sof, 2014/06/06 19:32:55]

You can remove this trace() OVERRIDE.

 
 protected:
     explicit MIDIController(PassOwnPtr<MIDIClient>);
 
 private:
     OwnPtr<MIDIClient> m_client;
 };
 
 } // namespace WebCore
 
 #endif // MIDIController_h