Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 317373005: Fix multiple rules generating icudtl.dat (Closed)

Created:
6 years, 6 months ago by cjhopman
Modified:
6 years, 6 months ago
CC:
newt (away), aurimas (slooooooooow)
Base URL:
https://chromium.googlesource.com/chromium/deps/icu46.git@master
Visibility:
Public.

Description

Fix multiple rules generating icudtl.dat The icudata target is built for multiple toolsets, but the outputs of the copies action are toolset-independent. Gyp then generates two different ninja rules to do the same copies action. To fix this, extract the copying of icudtl.dat to its own target that supports only a single toolset (so nobody accidentally depends on the wrong one) and then explicitly depend on that target+toolset from the icudata target. BUG=351052

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -14 lines) Patch
M icu.gyp View 2 chunks +26 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
cjhopman
mark: *
6 years, 6 months ago (2014-06-06 20:59:09 UTC) #1
cjhopman
+a couple people to cc as fyi
6 years, 6 months ago (2014-06-06 21:07:19 UTC) #2
Mark Mentovai
Jungshik should do the review (but LGTM if he approves it).
6 years, 6 months ago (2014-06-06 21:10:03 UTC) #3
jungshik at Google
Thank you for doing this and sorry that I didn't get back to this much ...
6 years, 6 months ago (2014-06-10 00:26:00 UTC) #4
jungshik at Google
On 2014/06/10 00:26:00, Jungshik Shin wrote: > Thank you for doing this and sorry that ...
6 years, 6 months ago (2014-06-10 00:26:28 UTC) #5
jungshik at Google
6 years, 6 months ago (2014-06-10 17:07:20 UTC) #6
On 2014/06/10 00:26:00, Jungshik Shin wrote:
> Thank you for doing this and sorry that I didn't get back to this much sooner.

> LGTM

I took this CL to apply to ICU 52, which will be rolled into the ToT (asas I got
the approval). For icu46 (used by M35-36), this CL will be still necessary if we
need to keep the build process saner in branches.

Powered by Google App Engine
This is Rietveld 408576698