Fix multiple rules generating icudtl.dat

icu.gyp

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'includes': [
     'icu.gypi',
   ],
   'variables': {
     'use_system_icu%': 0,
@@ skipping 51 matching lines @@
     'include_dirs': [
       'source/common',
       'source/i18n',
     ],
     'msvs_disabled_warnings': [4005, 4068, 4355, 4996, 4267],
   },
   'conditions': [
     ['use_system_icu==0 or want_separate_host_toolset==1', {
       'targets': [
         {
+          'target_name': 'copy_icudtl_dat',
+          'type': 'none',
+          # icudtl.dat is the same for both host/target, so this only supports a
+          # single toolset. If a target requires that the .dat file be copied
+          # to the output directory, it should explicitly depend on this target
+          # with the host toolset (like copy_icudtl_dat#host).
+          'toolsets': [ 'host' ],
+          'copies': [{
+            'destination': '<(PRODUCT_DIR)',
+            'conditions': [
+              ['OS == "android"', {
+                'files': [
+                  'android/icudtl.dat',
+                ],
+              } , { # else: OS != android
+                'files': [
+                  'source/data/in/icudtl.dat',
+                ],
+              }],
+            ],
+          }],
+        },
+        {
           'target_name': 'icudata',
           'type': 'static_library',
           'defines': [
             'U_HIDE_DATA_SYMBOL',
           ],
           'sources': [
              # These are hand-generated, but will do for now.  The linux
              # version is an identical copy of the (mac) icudt46l_dat.S file,
              # modulo removal of the .private_extern and .const directives and
              # with no leading underscore on the icudt46_dat symbol.
@@ skipping 24 matching lines @@
             }],
             [ 'icu_use_data_file_flag==1', {
               # Remove any assembly data file.
               'sources/': [['exclude', 'icudt46l_dat']],
               # Compile in the stub data symbol.
               'sources': ['source/stubdata/stubdata.c'],
 
               # Make sure any binary depending on this gets the data file.
               'conditions': [
                 ['OS != "ios"', {
-                  'copies': [{
-                    'destination': '<(PRODUCT_DIR)',
-                    'conditions': [
-                      ['OS == "android"', {
-                        'files': [
-                          'android/icudtl.dat',
-                        ],
-                      } , { # else: OS != android
-                        'files': [
-                          'source/data/in/icudtl.dat',
-                        ],
-                      }],
-                    ],
-                  }],
+                  'dependencies': [
+                    'copy_icudtl_dat#host',
+                  ],
                 } , { # else: OS=="ios"
                   'link_settings': {
                     'mac_bundle_resources': [
                       'source/data/in/icudtl.dat',
                     ],
                   },
                 }], # OS!=ios
               ], # conditions
             }], # icu_use_data_file_flag
           ], # conditions
@@ skipping 455 matching lines @@
           },
           'includes': [
             '../../build/shim_headers.gypi',
           ],
           'toolsets': ['target'],
         },
       ], # targets
     }],
   ], # conditions
 }