Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 317163006: Fix switch statement in DataFetcherSharedMemory::SetBufferAvailableState. (Closed)

Created:
6 years, 6 months ago by tonyg
Modified:
6 years, 6 months ago
Reviewers:
timvolodine
CC:
chromium-reviews, riju_, darin-cc_chromium.org, jam, timvolodine, Michael van Ouwerkerk
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix switch statement in DataFetcherSharedMemory::SetBufferAvailableState. I noticed this because a Telemetry unittest was triggering the NOTREACHED during session restore on Windows. I don't know much about this code, but the fallthroughs certainly look unintentional. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275425

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/browser/device_sensors/data_fetcher_shared_memory_win.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tonyg
6 years, 6 months ago (2014-06-06 05:15:02 UTC) #1
tonyg
On 2014/06/06 05:15:02, tonyg wrote: ps. Please CQ this if it looks good.
6 years, 6 months ago (2014-06-06 05:18:41 UTC) #2
timvolodine
yes that looks better indeed lgtm
6 years, 6 months ago (2014-06-06 10:41:32 UTC) #3
timvolodine
The CQ bit was checked by timvolodine@chromium.org
6 years, 6 months ago (2014-06-06 10:41:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/317163006/1
6 years, 6 months ago (2014-06-06 10:42:44 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 13:30:42 UTC) #6
Message was sent while issue was closed.
Change committed as 275425

Powered by Google App Engine
This is Rietveld 408576698