Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issue 316923002: Perf server initial documentation; mostly placeholder now. (Closed)

Created:
6 years, 6 months ago by benchen
Modified:
6 years, 6 months ago
Reviewers:
borenet, rmistry
CC:
skia-review_googlegroups.com, skiabot_google.com, robertphillips, bsalomon
Base URL:
https://skia.googlesource.com/buildbot.git@master
Visibility:
Public.

Description

Perf server initial documentation; mostly placeholder now. BUG=skia: TBR=rmistry Committed: https://skia.googlesource.com/buildbot/+/df1a19beb97ed159eefe38d6c82ee5c141856781

Patch Set 1 #

Total comments: 10

Patch Set 2 : Some rearrangements. #

Patch Set 3 : fix typos and formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -0 lines) Patch
A compute_engine_scripts/perfserver/README View 1 1 chunk +15 lines, -0 lines 0 comments Download
A compute_engine_scripts/perfserver/vm_create_server.sh View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
A compute_engine_scripts/perfserver/vm_delete_server.sh View 1 1 chunk +8 lines, -0 lines 0 comments Download
A compute_engine_scripts/perfserver/vm_setup_server.sh View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
A perf/server/DESIGN.md View 1 2 1 chunk +70 lines, -0 lines 0 comments Download
A perf/server/README.md View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
benchen
This is just to get things started. Will edit along the way.
6 years, 6 months ago (2014-06-04 13:47:14 UTC) #1
rmistry
https://codereview.chromium.org/316923002/diff/1/compute_engine_scripts/perfserver/vm_setup_server.sh File compute_engine_scripts/perfserver/vm_setup_server.sh (right): https://codereview.chromium.org/316923002/diff/1/compute_engine_scripts/perfserver/vm_setup_server.sh#newcode5 compute_engine_scripts/perfserver/vm_setup_server.sh:5: # Copyright 2014 Google Inc. All Rights Reserved. Lets ...
6 years, 6 months ago (2014-06-04 13:59:18 UTC) #2
borenet
https://codereview.chromium.org/316923002/diff/1/compute_engine_scripts/perfserver/vm_setup_server.sh File compute_engine_scripts/perfserver/vm_setup_server.sh (right): https://codereview.chromium.org/316923002/diff/1/compute_engine_scripts/perfserver/vm_setup_server.sh#newcode5 compute_engine_scripts/perfserver/vm_setup_server.sh:5: # Copyright 2014 Google Inc. All Rights Reserved. Also, ...
6 years, 6 months ago (2014-06-04 14:04:46 UTC) #3
benchen
No I have a better idea on where to put what. PTAL, thanks! https://codereview.chromium.org/316923002/diff/1/compute_engine_scripts/perfserver/vm_setup_server.sh File ...
6 years, 6 months ago (2014-06-04 15:23:31 UTC) #4
benchen
oops, I meant "NOW I have a better idea..."
6 years, 6 months ago (2014-06-04 15:24:05 UTC) #5
rmistry
https://codereview.chromium.org/316923002/diff/1/perf/server/README.md File perf/server/README.md (right): https://codereview.chromium.org/316923002/diff/1/perf/server/README.md#newcode16 perf/server/README.md:16: --persistent_boot_disk On 2014/06/04 15:23:32, benchen wrote: > Got it. ...
6 years, 6 months ago (2014-06-04 15:26:45 UTC) #6
benchen
Submitting the placeholders now.
6 years, 6 months ago (2014-06-04 16:06:43 UTC) #7
benchen
The CQ bit was checked by bensong@google.com
6 years, 6 months ago (2014-06-04 16:06:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bensong@google.com/316923002/40001
6 years, 6 months ago (2014-06-04 16:07:44 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 16:07:57 UTC) #10
Message was sent while issue was closed.
Change committed as df1a19beb97ed159eefe38d6c82ee5c141856781

Powered by Google App Engine
This is Rietveld 408576698