third_party/ocmock/README.chromium - Issue 316873003: Add a workaround to compare types in mocked method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/ocmock/README.chromium

Issue 316873003: Add a workaround to compare types in mocked method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add note in README.chromium and sync with upstream pull request Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/ocmock/README.chromium

diff --git a/third_party/ocmock/README.chromium b/third_party/ocmock/README.chromium

index 666072a86b2760f4ba0eb0efbbd8f1d39731985f..dec968a3fa81a1af0701c3f3bad5aed4dc03b04b 100644

--- a/third_party/ocmock/README.chromium

+++ b/third_party/ocmock/README.chromium

@@ -31,3 +31,9 @@ Chromium also patches in 77400c22b5bafd8aaaa75f90a1d997838204577a that fixes

the comparison of types between invocation return type description (which

changed from "c" to "B" on arm64) and NSValue objCType (which didn't change)

on arm64 for BOOL values.

+Chromium does patch OCMBoxedReturnValueProvider.m to handle comparison of

+return type and value type for C++ objects when compiling with clang and

+using libc++ STL library. The file is renamed OCMBoxedReturnValueProvider.mm

+to be compiled as an Objective-C++ class to allow detection of the C++ STL

+library used. Pull request: https://github.com/erikdoe/ocmock/pull/97