Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(860)

Issue 316863002: Rename "managed (mode|user)" to "supervised user" (part 1) (Closed)

Created:
6 years, 6 months ago by Marc Treib
Modified:
6 years, 3 months ago
CC:
chromium-reviews, tim+watch_chromium.org, extensions-reviews_chromium.org, sadrul, kalyank, chrome-apps-syd-reviews_chromium.org, estade+watch_chromium.org, benjhayden+dwatch_chromium.org, yoshiki+watch_chromium.org, asanka, dbeam+watch-ntp_chromium.org, haitaol+watch_chromium.org, dbeam+watch-options_chromium.org, rginda+watch_chromium.org, pam+watch_chromium.org, tfarina, chromium-apps-reviews_chromium.org, pedrosimonetti+watch_chromium.org, ben+ash_chromium.org, maniscalco+watch_chromium.org
Visibility:
Public.

Description

Rename "managed (mode|user)" to "supervised user" (part 1) This CL changes: - "IsManaged" and similar methods in Profile, ProfileInfoCache, and a few other places (which mostly forward to either of those) - Enum and constant names - Variable names - Comments Still missing: - I almost certainly missed a few variables and comments - The actual SU implementation, i.e. c/b/managed_mode/ - JavaScript - Resource names But since this CL is already way too huge, I'll try to commit this part now and do the rest in one or more followup CLs. TBR=thakis@chromium.org (chrome/) TBR=rogerta@chromium.org (google_apis/) TBR=haitaol@chromium.org (sync/ and components/sync_driver/) All the TBRs are simple renames. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276722

Patch Set 1 #

Patch Set 2 : fix CrOS, maybe Mac #

Patch Set 3 : fix Mac (?) #

Patch Set 4 : more Mac fixes #

Patch Set 5 : Rebase+test fix #

Patch Set 6 : rebase #

Patch Set 7 : rebase #

Patch Set 8 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+772 lines, -740 lines) Patch
M chrome/browser/app_controller_mac.mm View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/fake_login_utils.cc View 1 2 3 4 5 6 7 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/managed/managed_user_test_base.cc View 1 2 3 4 5 6 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/session/session_manager.cc View 1 2 3 4 5 6 7 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/profiles/avatar_menu_actions_chromeos.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/profiles/profile_list_chromeos.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_service_test_base.h View 1 2 3 4 5 6 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_service_test_base.cc View 1 2 3 4 5 6 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/extensions/external_provider_impl.cc View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/webstore_startup_installer_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/managed_mode/managed_mode_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/managed_mode/managed_mode_interstitial.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/managed_mode/managed_mode_resource_throttle_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/managed_mode/managed_user_refresh_token_fetcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/managed_mode/managed_user_registration_utility.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/managed_mode/managed_user_registration_utility_unittest.cc View 8 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/managed_mode/managed_user_service.cc View 1 2 3 4 5 6 19 chunks +38 lines, -35 lines 0 comments Download
M chrome/browser/managed_mode/managed_user_service_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/managed_mode/managed_user_service_unittest.cc View 1 2 3 4 5 6 6 chunks +11 lines, -9 lines 0 comments Download
M chrome/browser/managed_mode/managed_user_settings_service.cc View 1 2 3 4 5 6 7 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/managed_mode/managed_user_settings_service_unittest.cc View 1 2 3 4 5 6 6 chunks +10 lines, -7 lines 0 comments Download
M chrome/browser/managed_mode/managed_user_shared_settings_service.cc View 10 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/managed_mode/managed_user_shared_settings_service_unittest.cc View 8 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/managed_mode/managed_user_sync_service.cc View 13 chunks +17 lines, -17 lines 0 comments Download
M chrome/browser/managed_mode/managed_user_sync_service_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/managed_mode/managed_user_theme.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/managed_mode/supervised_user_pref_mapping_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/managed_mode/supervised_user_pref_mapping_service_unittest.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/managed_mode/supervised_user_pref_store.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/managed_mode/supervised_user_pref_store_unittest.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/configuration_policy_handler_list_factory.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/avatar_menu.h View 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/profiles/avatar_menu.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/profiles/avatar_menu_actions_desktop.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 2 3 4 5 5 chunks +11 lines, -10 lines 0 comments Download
M chrome/browser/profiles/profile_info_cache.h View 3 chunks +9 lines, -10 lines 0 comments Download
M chrome/browser/profiles/profile_info_cache.cc View 7 chunks +27 lines, -23 lines 0 comments Download
M chrome/browser/profiles/profile_info_cache_unittest.cc View 4 chunks +26 lines, -24 lines 0 comments Download
M chrome/browser/profiles/profile_info_interface.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_list_desktop.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile_manager.h View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 15 chunks +35 lines, -33 lines 0 comments Download
M chrome/browser/profiles/profile_manager_unittest.cc View 1 2 3 4 5 chunks +22 lines, -19 lines 0 comments Download
M chrome/browser/profiles/profile_metrics.cc View 1 2 3 4 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/signin/chrome_signin_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/signin_promo.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/synced_tab_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/synced_tab_delegate_android.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/synced_tab_delegate_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/managed_user_signin_manager_wrapper.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/profile_sync_components_factory_impl.cc View 1 2 3 4 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/sync/profile_sync_components_factory_impl_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/sessions/notification_service_sessions_router.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/sessions/sessions_sync_manager.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/sessions/sessions_sync_manager_unittest.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/sync/sessions/sessions_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/startup_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/enable_disable_test.cc View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/test/integration/profile_sync_service_harness.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/single_client_managed_user_settings_sync_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/themes/custom_theme_supplier.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/themes/theme_properties.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/themes/theme_service.h View 1 chunk +5 lines, -8 lines 0 comments Download
M chrome/browser/themes/theme_service.cc View 4 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/themes/theme_service_unittest.cc View 1 2 3 4 5 6 5 chunks +14 lines, -13 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_service_impl.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_service_mac.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_service_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_view_delegate.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/profile_store.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/test/fake_profile.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/test/fake_profile.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/test/fake_profile_store.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/test/fake_profile_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_utils.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/profiles/avatar_icon_controller.mm View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/avatar_icon_controller_unittest.mm View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/avatar_label_button.mm View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/avatar_menu_bubble_controller.mm View 1 2 9 chunks +18 lines, -17 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm View 1 2 3 4 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_menu_controller.mm View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_browsertest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/sync/tab_contents_synced_tab_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/sync/tab_contents_synced_tab_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/profiles/avatar_label.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/profiles/avatar_label.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/profiles/avatar_menu_bubble_view.h View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/profiles/avatar_menu_bubble_view.cc View 1 2 3 4 8 chunks +23 lines, -22 lines 0 comments Download
M chrome/browser/ui/views/profiles/new_avatar_button.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 1 2 3 4 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/downloads_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/downloads_ui_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/history_ui.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_login_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_resource_cache.cc View 1 2 3 4 5 6 7 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 2 3 4 5 6 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/options/clear_browser_data_handler.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/create_profile_handler.h View 4 chunks +21 lines, -20 lines 0 comments Download
M chrome/browser/ui/webui/options/create_profile_handler.cc View 10 chunks +39 lines, -37 lines 0 comments Download
M chrome/browser/ui/webui/options/manage_profile_handler.h View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/options/manage_profile_handler.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/options/managed_user_import_handler.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/options/options_handlers_helper.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/signin/user_manager_screen_handler.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M chrome/common/chrome_constants.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_constants.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_paths.h View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/chrome_paths.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_switches.h View 1 2 3 4 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 3 4 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/common/pref_names.h View 1 2 3 4 5 3 chunks +10 lines, -10 lines 0 comments Download
M chrome/common/pref_names.cc View 1 2 3 4 5 3 chunks +16 lines, -16 lines 0 comments Download
M chrome/common/url_constants.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/url_constants.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/testing_profile.h View 5 chunks +7 lines, -7 lines 0 comments Download
M chrome/test/base/testing_profile.cc View 1 2 3 4 5 6 5 chunks +8 lines, -8 lines 0 comments Download
M chrome/test/base/testing_profile_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/base/testing_profile_manager.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/sync_driver/model_association_manager.cc View 1 2 3 4 2 chunks +5 lines, -5 lines 0 comments Download
M components/sync_driver/pref_names.h View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M components/sync_driver/pref_names.cc View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M components/sync_driver/sync_prefs.cc View 1 2 3 4 2 chunks +7 lines, -7 lines 0 comments Download
M google_apis/gaia/gaia_constants.h View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gaia/gaia_constants.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/public/base/model_type.h View 1 2 3 4 1 chunk +9 lines, -9 lines 0 comments Download
M sync/syncable/model_type.cc View 1 2 3 4 13 chunks +45 lines, -44 lines 0 comments Download
M sync/util/data_type_histogram.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Marc Treib
6 years, 6 months ago (2014-06-11 14:21:13 UTC) #1
Pam (message me for reviews)
c/b/managed_mode/* LGTM, but please note the request below. The rest rubber-stamped without review, under the ...
6 years, 6 months ago (2014-06-11 22:57:15 UTC) #2
Marc Treib
On 2014/06/11 22:57:15, Pam (also PM for reviews) wrote: > c/b/managed_mode/* LGTM, but please note ...
6 years, 6 months ago (2014-06-12 08:48:48 UTC) #3
Marc Treib
The CQ bit was checked by treib@chromium.org
6 years, 6 months ago (2014-06-12 11:04:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/316863002/120001
6 years, 6 months ago (2014-06-12 11:07:45 UTC) #5
Marc Treib
The CQ bit was unchecked by treib@chromium.org
6 years, 6 months ago (2014-06-12 12:16:55 UTC) #6
Marc Treib
The CQ bit was checked by treib@chromium.org
6 years, 6 months ago (2014-06-12 12:26:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/316863002/140001
6 years, 6 months ago (2014-06-12 12:27:26 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 17:14:12 UTC) #9
Message was sent while issue was closed.
Change committed as 276722

Powered by Google App Engine
This is Rietveld 408576698