Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 316643003: DM: SKP source / PDF backend (Closed)

Created:
6 years, 6 months ago by mtklein_C
Modified:
6 years, 6 months ago
Reviewers:
hal.canary, mtklein
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

DM: SKP source / PDF backend Removed expectations code for PDF backend for now, given that we don't have any, and refactored a little to make that cleaner. We can now test .skp -> .pdf -> .png in DM. Neat eh? BUG=skia:2598 Committed: https://skia.googlesource.com/skia/+/e4d3e605f74a23d050abad29909af421d8b1cf1a

Patch Set 1 #

Patch Set 2 : stray nl #

Patch Set 3 : cast #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -60 lines) Patch
M dm/DM.cpp View 2 chunks +17 lines, -16 lines 0 comments Download
M dm/DMCpuGMTask.h View 1 chunk +1 line, -1 line 0 comments Download
M dm/DMCpuGMTask.cpp View 1 chunk +1 line, -1 line 0 comments Download
M dm/DMGpuGMTask.h View 1 chunk +1 line, -1 line 0 comments Download
M dm/DMGpuGMTask.cpp View 1 chunk +1 line, -1 line 0 comments Download
M dm/DMPDFRasterizeTask.h View 3 chunks +0 lines, -3 lines 0 comments Download
M dm/DMPDFRasterizeTask.cpp View 1 chunk +3 lines, -7 lines 0 comments Download
M dm/DMPDFTask.h View 2 chunks +13 lines, -5 lines 0 comments Download
M dm/DMPDFTask.cpp View 1 2 4 chunks +29 lines, -15 lines 0 comments Download
M dm/DMSKPTask.cpp View 1 chunk +1 line, -10 lines 0 comments Download
M dm/DMUtil.h View 1 chunk +3 lines, -0 lines 0 comments Download
M dm/DMUtil.cpp View 1 2 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
mtklein
6 years, 6 months ago (2014-06-03 22:28:16 UTC) #1
mtklein
ping?
6 years, 6 months ago (2014-06-06 15:15:19 UTC) #2
hal.canary
On 2014/06/06 15:15:19, mtklein wrote: > ping? LGTM - we'll have to add expectations back ...
6 years, 6 months ago (2014-06-06 15:18:40 UTC) #3
mtklein
On 2014/06/06 15:18:40, Hal Canary wrote: > On 2014/06/06 15:15:19, mtklein wrote: > > ping? ...
6 years, 6 months ago (2014-06-06 15:19:19 UTC) #4
mtklein
6 years, 6 months ago (2014-06-06 15:19:32 UTC) #5
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 6 months ago (2014-06-06 15:19:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/316643003/20001
6 years, 6 months ago (2014-06-06 15:19:55 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: Build-Win7-VS2010-x86-Debug-Trybot on tryserver.chromium ...
6 years, 6 months ago (2014-06-06 15:46:15 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 16:05:06 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win7-VS2010-x86-Debug-Trybot on tryserver.chromium (http://108.170.220.76:10117/builders/Build-Win7-VS2010-x86-Debug-Trybot/builds/258)
6 years, 6 months ago (2014-06-06 16:05:07 UTC) #10
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 6 months ago (2014-06-06 16:11:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/316643003/40001
6 years, 6 months ago (2014-06-06 16:11:16 UTC) #12
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 16:28:48 UTC) #13
Message was sent while issue was closed.
Change committed as e4d3e605f74a23d050abad29909af421d8b1cf1a

Powered by Google App Engine
This is Rietveld 408576698