LayoutTests/fast/dom/Attr/update-attribute-node-no-crash.html - Issue 316583002: Correctly handle accessing a replaced Attr object's attribute value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/dom/Attr/update-attribute-node-no-crash.html

Issue 316583002: Correctly handle accessing a replaced Attr object's attribute value. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Have Attr track local name of attached attribute, if needed. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: LayoutTests/fast/dom/Attr/update-attribute-node-no-crash.html

diff --git a/LayoutTests/fast/dom/Attr/update-attribute-node-no-crash.html b/LayoutTests/fast/dom/Attr/update-attribute-node-no-crash.html

new file mode 100644

index 0000000000000000000000000000000000000000..db9b7167be160ea525c0542c69546d37fb57618a

--- /dev/null

+++ b/LayoutTests/fast/dom/Attr/update-attribute-node-no-crash.html

@@ -0,0 +1,26 @@

+<!DOCTYPE HTML>

+<html>

+<head>

+<script src="../../../resources/js-test.js"></script>

+</head>

+<body>

+<iframe></iframe>

+<div id="test" style="background-color: red"></div>

+<script>

+description("Updating value of replaced attribute node");

+var element = document.getElementById("test");

+var attr = document.createAttribute("STYLE");

+// This aligns with Trident rather than Gecko.

adamk 2014/06/05 00:26:34 Sounds like we're getting no help from the DOM spe

sof 2014/06/05 06:58:26 Yes, thoroughly removed from sight there. The set

+shouldBeEqualToString("replaced = element.setAttributeNode(attr); replaced.name", "STYLE");

+shouldBeEqualToString("replaced.value", "background-color: red");

+shouldBeEqualToString("attr.name", "STYLE");

+shouldBeEqualToString("attr.value", "");

+shouldBeEqualToString("element.getAttribute('style')", "");

+shouldBeEqualToString("element.getAttribute('StyLE')", "");

+// Setting the value must correctly locate attribute on the element and update it,

+// even if the local name differs. PASS if no crash (crbug.com/376718)

+shouldBeEqualToString("attr.value = 'background-color: green'; attr.value", "background-color: green");

+shouldBeEqualToString("element.getAttribute('stylE')", "background-color: green");

+</script>

+</body>

+</html>

« no previous file with comments | « no previous file | LayoutTests/fast/dom/Attr/update-attribute-node-no-crash-expected.txt » ('j') | no next file with comments »