LayoutTests/fast/dom/Attr/update-attribute-node-no-crash.html - Issue 316583002: Correctly handle accessing a replaced Attr object's attribute value.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/Attr/update-attribute-node-no-crash.html

Issue 316583002: Correctly handle accessing a replaced Attr object's attribute value. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Have Attr track local name of attached attribute, if needed. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>

	2 <html>

	3 <head>

	4 <script src="../../../resources/js-test.js"></script>

	5 </head>

	6 <body>

	7 <iframe></iframe>

	8 <div id="test" style="background-color: red"></div>

	9 <script>

	10 description("Updating value of replaced attribute node");

	11 var element = document.getElementById("test");

	12 var attr = document.createAttribute("STYLE");

	13 // This aligns with Trident rather than Gecko.
	adamk 2014/06/05 00:26:34 Sounds like we're getting no help from the DOM spe Sounds like we're getting no help from the DOM spec here, since setAttributeNode is deprecated? sof 2014/06/05 06:58:26 Yes, thoroughly removed from sight there. The set Show quoted text On 2014/06/05 00:26:34, adamk wrote: > Sounds like we're getting no help from the DOM spec here, since setAttributeNode > is deprecated? Yes, thoroughly removed from sight there. The setAttributeNode() text in the DOM Level1 spec sides with Gecko I'd say ("the previously existing Attr node is returned".) Presto follows WebKit + Blink as well. Doing spec compat changes here is questionable at this stage; I've added a FIXME in setAttributeNode() about it though, so that it isn't forgotten about completely.
	14 shouldBeEqualToString("replaced = element.setAttributeNode(attr); replaced.name" , "STYLE");

	15 shouldBeEqualToString("replaced.value", "background-color: red");

	16 shouldBeEqualToString("attr.name", "STYLE");

	17 shouldBeEqualToString("attr.value", "");

	18 shouldBeEqualToString("element.getAttribute('style')", "");

	19 shouldBeEqualToString("element.getAttribute('StyLE')", "");

	20 // Setting the value must correctly locate attribute on the element and update i t,

	21 // even if the local name differs. PASS if no crash (crbug.com/376718)

	22 shouldBeEqualToString("attr.value = 'background-color: green'; attr.value", "bac kground-color: green");

	23 shouldBeEqualToString("element.getAttribute('stylE')", "background-color: green" );

	24 </script>

	25 </body>

	26 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/dom/Attr/update-attribute-node-no-crash-expected.txt » ('j') | no next file with comments »