Change Help page title to About.

Change Help page title to About.

The Help page (chrome://help) should be called "About". This changes
the page title and header, and the link in the uber frame sidebar.

BUG=381794
R=dbeam@chromium.org
TBR=sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275643

[Dan Beam, 2014-06-05 22:45:25]

please add a BUG= and tell me who OK'd this change

[michaelpg, 2014-06-06 20:54:23]

On 2014/06/05 22:45:25, Dan Beam wrote:
> please add a BUG= and tell me who OK'd this change

Done. Issue 381794, approved by rolfe@ and confirmed by glen@.

[Dan Beam, 2014-06-06 21:11:24]

lgtm w/renaming license

https://codereview.chromium.org/316343002/diff/1/chrome/browser/ui/webui/uber...
File chrome/browser/ui/webui/uber/uber_ui.cc (right):

https://codereview.chromium.org/316343002/diff/1/chrome/browser/ui/webui/uber...
chrome/browser/ui/webui/uber/uber_ui.cc:111:
source->AddLocalizedString("helpDisplayName", IDS_ABOUT_TITLE);
nit: maybe rename helpDisplayName and all the other stuff regarding help?

[sky, 2014-06-06 21:42:55]

LGTM

[michaelpg, 2014-06-06 21:56:28]

On 2014/06/06 21:11:24, Dan Beam wrote:
> lgtm w/renaming license
> 
>
https://codereview.chromium.org/316343002/diff/1/chrome/browser/ui/webui/uber...
> File chrome/browser/ui/webui/uber/uber_ui.cc (right):
> 
>
https://codereview.chromium.org/316343002/diff/1/chrome/browser/ui/webui/uber...
> chrome/browser/ui/webui/uber/uber_ui.cc:111:
> source->AddLocalizedString("helpDisplayName", IDS_ABOUT_TITLE);
> nit: maybe rename helpDisplayName and all the other stuff regarding help?

not worth changing right now. Next step is to show About in the Settings page
when the flag is 1, which means some restructuring of "help" files. I'll
s/help/about/g then.

[michaelpg, 2014-06-06 21:56:42]

The CQ bit was checked by michaelpg@chromium.org

[commit-bot: I haz the power, 2014-06-06 21:58:52]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/michaelpg@chromium.org/316343002/1

[commit-bot: I haz the power, 2014-06-07 03:18:41]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-06-07 08:20:29]

Change committed as 275643