Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Side by Side Diff: chrome/browser/ui/webui/uber/uber_ui.cc

Issue 316343002: Change Help page title to About. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/ui/webui/help/help_handler.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/uber/uber_ui.h" 5 #include "chrome/browser/ui/webui/uber/uber_ui.h"
6 6
7 #include "base/stl_util.h" 7 #include "base/stl_util.h"
8 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
9 #include "chrome/browser/chrome_notification_types.h" 9 #include "chrome/browser/chrome_notification_types.h"
10 #include "chrome/browser/extensions/extension_service.h" 10 #include "chrome/browser/extensions/extension_service.h"
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
101 #else 101 #else
102 source->AddLocalizedString("shortProductName", IDS_SHORT_PRODUCT_NAME); 102 source->AddLocalizedString("shortProductName", IDS_SHORT_PRODUCT_NAME);
103 #endif // defined(OS_CHROMEOS) 103 #endif // defined(OS_CHROMEOS)
104 104
105 source->AddString("extensionsHost", 105 source->AddString("extensionsHost",
106 ASCIIToUTF16(chrome::kChromeUIExtensionsHost)); 106 ASCIIToUTF16(chrome::kChromeUIExtensionsHost));
107 source->AddLocalizedString("extensionsDisplayName", 107 source->AddLocalizedString("extensionsDisplayName",
108 IDS_MANAGE_EXTENSIONS_SETTING_WINDOWS_TITLE); 108 IDS_MANAGE_EXTENSIONS_SETTING_WINDOWS_TITLE);
109 source->AddString("helpHost", 109 source->AddString("helpHost",
110 ASCIIToUTF16(chrome::kChromeUIHelpHost)); 110 ASCIIToUTF16(chrome::kChromeUIHelpHost));
111 source->AddLocalizedString("helpDisplayName", IDS_HELP_TITLE); 111 source->AddLocalizedString("helpDisplayName", IDS_ABOUT_TITLE);
Dan Beam 2014/06/06 21:11:23 nit: maybe rename helpDisplayName and all the othe
112 source->AddString("historyHost", 112 source->AddString("historyHost",
113 ASCIIToUTF16(chrome::kChromeUIHistoryHost)); 113 ASCIIToUTF16(chrome::kChromeUIHistoryHost));
114 source->AddLocalizedString("historyDisplayName", IDS_HISTORY_TITLE); 114 source->AddLocalizedString("historyDisplayName", IDS_HISTORY_TITLE);
115 source->AddString("settingsHost", 115 source->AddString("settingsHost",
116 ASCIIToUTF16(chrome::kChromeUISettingsHost)); 116 ASCIIToUTF16(chrome::kChromeUISettingsHost));
117 source->AddLocalizedString("settingsDisplayName", IDS_SETTINGS_TITLE); 117 source->AddLocalizedString("settingsDisplayName", IDS_SETTINGS_TITLE);
118 bool overridesHistory = HasExtensionType(profile, 118 bool overridesHistory = HasExtensionType(profile,
119 chrome::kChromeUIHistoryHost); 119 chrome::kChromeUIHistoryHost);
120 source->AddString("overridesHistory", 120 source->AddString("overridesHistory",
121 ASCIIToUTF16(overridesHistory ? "yes" : "no")); 121 ASCIIToUTF16(overridesHistory ? "yes" : "no"));
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
229 web_ui()->CallJavascriptFunction( 229 web_ui()->CallJavascriptFunction(
230 "uber_frame.setNavigationOverride", 230 "uber_frame.setNavigationOverride",
231 base::StringValue(chrome::kChromeUIHistoryHost), 231 base::StringValue(chrome::kChromeUIHistoryHost),
232 base::StringValue(overrides_history ? "yes" : "no")); 232 base::StringValue(overrides_history ? "yes" : "no"));
233 break; 233 break;
234 } 234 }
235 default: 235 default:
236 NOTREACHED(); 236 NOTREACHED();
237 } 237 }
238 } 238 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/webui/help/help_handler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698