Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(801)

Unified Diff: master/skia_master_scripts/commands.py

Issue 316333002: display "latest GM failures" link in its own line under build step Base URL: https://skia.googlesource.com/buildbot.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | master/skia_master_scripts/factory.py » ('j') | master/skia_master_scripts/factory.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: master/skia_master_scripts/commands.py
diff --git a/master/skia_master_scripts/commands.py b/master/skia_master_scripts/commands.py
index f25f05350e914a60b7e46f778cc503d311b34b26..52b2dd5d948bdcb5eecd3186afbf74fba0e4c089 100644
--- a/master/skia_master_scripts/commands.py
+++ b/master/skia_master_scripts/commands.py
@@ -70,7 +70,8 @@ class SkiaCommands(commands.FactoryCommands):
# TODO(borenet): Can kwargs be used to simplify this function declaration?
def AddSlaveScript(self, script, args, description, timeout=None,
halt_on_failure=False, is_upload_step=False,
- is_rebaseline_step=False, get_props_from_stdout=None,
+ is_rebaseline_step=False,
+ get_links_from_stdout=None, get_props_from_stdout=None,
workdir=None, do_step_if=None,
always_run=False, flunk_on_failure=True,
exception_on_failure=False):
@@ -86,6 +87,7 @@ class SkiaCommands(commands.FactoryCommands):
halt_on_failure=halt_on_failure,
is_upload_step=is_upload_step,
is_rebaseline_step=is_rebaseline_step,
+ get_links_from_stdout=get_links_from_stdout,
get_props_from_stdout=get_props_from_stdout,
workdir=use_workdir,
do_step_if=do_step_if,
@@ -96,7 +98,8 @@ class SkiaCommands(commands.FactoryCommands):
# TODO(borenet): Can kwargs be used to simplify this function declaration?
def AddRunCommand(self, command, description='Run', timeout=None,
halt_on_failure=False, is_upload_step=False,
- is_rebaseline_step=False, get_props_from_stdout=None,
+ is_rebaseline_step=False,
+ get_links_from_stdout=None, get_props_from_stdout=None,
workdir=None, do_step_if=None, always_run=False,
flunk_on_failure=True, exception_on_failure=False):
"""Runs an arbitrary command, perhaps a binary we built."""
@@ -113,6 +116,7 @@ class SkiaCommands(commands.FactoryCommands):
self.factory.addStep(skia_build_step.SkiaBuildStep,
is_upload_step=is_upload_step,
is_rebaseline_step=is_rebaseline_step,
+ get_links_from_stdout=get_links_from_stdout,
get_props_from_stdout=get_props_from_stdout,
description=description, timeout=timeout,
command=command, workdir=workdir or self.workdir,
« no previous file with comments | « no previous file | master/skia_master_scripts/factory.py » ('j') | master/skia_master_scripts/factory.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698