Index: master/skia_master_scripts/factory.py |
diff --git a/master/skia_master_scripts/factory.py b/master/skia_master_scripts/factory.py |
index 97ae2a2c959874adc771903b407aff3509251c69..e68e8a824e65b777b99383f7167b784cc811d52f 100644 |
--- a/master/skia_master_scripts/factory.py |
+++ b/master/skia_master_scripts/factory.py |
@@ -248,7 +248,8 @@ class SkiaFactory(BuildFactory): |
def AddSlaveScript(self, script, description, args=None, timeout=None, |
halt_on_failure=False, |
is_upload_render_step=False, is_upload_bench_step=False, |
- is_rebaseline_step=False, get_props_from_stdout=None, |
+ is_rebaseline_step=False, |
+ get_links_from_stdout=None, get_props_from_stdout=None, |
workdir=None, do_step_if=None, always_run=False, |
flunk_on_failure=True, exception_on_failure=False): |
""" Add a BuildStep consisting of a python script. |
@@ -267,6 +268,10 @@ class SkiaFactory(BuildFactory): |
self._do_upload_bench_results is True |
is_rebaseline_step: boolean indicating whether this step is required for |
rebaseline-only builds. |
+ get_links_from_stdout: optional dictionary. Keys are strings indicating |
+ link text to set based on the output of this step. Values are |
+ strings containing regular expressions for parsing the linked URL from |
+ the output of the step. |
get_props_from_stdout: optional dictionary. Keys are strings indicating |
build properties to set based on the output of this step. Values are |
strings containing regular expressions for parsing the property from |
@@ -305,6 +310,7 @@ class SkiaFactory(BuildFactory): |
halt_on_failure=halt_on_failure, |
is_upload_step=is_upload_render_step or is_upload_bench_step, |
is_rebaseline_step=is_rebaseline_step, |
+ get_links_from_stdout=get_links_from_stdout, |
get_props_from_stdout=get_props_from_stdout, |
workdir=workdir, |
do_step_if=do_step_if, |
@@ -532,8 +538,8 @@ class SkiaFactory(BuildFactory): |
"""Compare the actually-generated GM images to the checked-in baselines.""" |
self.AddSlaveScript(script='compare_gms.py', |
description='CompareGMs', |
- get_props_from_stdout={ |
- 'latest_gm_failures_url': |
+ get_links_from_stdout={ |
+ 'Latest GM failures on this builder': |
epoger
2014/06/05 22:15:36
For more flexibility, we could even allow the clie
borenet
2014/06/06 12:10:34
This makes me wish we had better performance measu
epoger
2014/06/09 13:33:28
I think those functions sound like a good idea. A
|
'%s([^\n]*)\n' % skia_vars.GetGlobalVariable( |
'latest_gm_failures_preamble')}, |
is_rebaseline_step=True) |