Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 316313002: Unflake plugins/attach-during-destroy.html and plugins/destroy-reentry.html (Closed)

Created:
6 years, 6 months ago by dcheng
Modified:
6 years, 6 months ago
Reviewers:
Nate Chapin
CC:
blink-reviews
Visibility:
Public.

Description

Unflake plugins/attach-during-destroy.html and plugins/destroy-reentry.html BUG=380167 R=japhet@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175617

Patch Set 1 #

Patch Set 2 : Fix destroy-reentry.html too #

Patch Set 3 : Merge a bunch of results #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -52 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/platform/android/plugins/attach-during-destroy-expected.txt View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
D LayoutTests/platform/linux/plugins/attach-during-destroy-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/platform/mac-lion/plugins/attach-during-destroy-expected.txt View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
D LayoutTests/platform/mac/plugins/attach-during-destroy-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/plugins/attach-during-destroy.html View 2 chunks +24 lines, -12 lines 0 comments Download
M LayoutTests/plugins/attach-during-destroy-expected.txt View 1 2 1 chunk +1 line, -6 lines 0 comments Download
M LayoutTests/plugins/destroy-reentry.html View 1 2 chunks +24 lines, -13 lines 0 comments Download
M LayoutTests/plugins/destroy-reentry-expected.txt View 1 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Nate Chapin
lgtm
6 years, 6 months ago (2014-06-05 22:34:37 UTC) #1
dcheng
PTAL. I updated destroy-reentry.html which uses the exact same pattern. I also updated the expected ...
6 years, 6 months ago (2014-06-05 22:41:25 UTC) #2
Nate Chapin
LGTM
6 years, 6 months ago (2014-06-05 22:42:23 UTC) #3
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 6 months ago (2014-06-05 22:43:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/316313002/20001
6 years, 6 months ago (2014-06-05 22:44:19 UTC) #5
dcheng
6 years, 6 months ago (2014-06-06 01:28:57 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r175617 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698