LayoutTests/plugins/destroy-reentry.html - Issue 316313002: Unflake plugins/attach-during-destroy.html and plugins/destroy-reentry.html

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/plugins/destroy-reentry.html

Issue 316313002: Unflake plugins/attach-during-destroy.html and plugins/destroy-reentry.html (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Merge a bunch of results Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: LayoutTests/plugins/destroy-reentry.html

diff --git a/LayoutTests/plugins/destroy-reentry.html b/LayoutTests/plugins/destroy-reentry.html

index fd8578aff6ca541c15d4b2c06d48c949dcf837b4..73c345cd1333965186d72346e5f9c6d055941b5c 100644

--- a/LayoutTests/plugins/destroy-reentry.html

+++ b/LayoutTests/plugins/destroy-reentry.html

@@ -1,12 +1,6 @@

-<p>

- Test for <i><a href="rdar://problem/6937089">rdar://problem/6937089</a> Crashes at RenderWidget::destroy()</i>.

-</p>

-<p>

- This test should not crash or cause an assertion failure.

-</p>

-<div id="target">

- <embed type="application/x-webkit-test-netscape" ondestroy="destroyed()">

-</div>

+<!DOCTYPE html>

+<html>

+<head>

function destroyed()

{

@@ -14,9 +8,26 @@

target.parentNode.removeChild(target);

}

- if (window.testRunner)

- testRunner.dumpAsText();

+ function loaded()

+ {

+ if (window.testRunner) {

+ testRunner.dumpAsText();

+ testRunner.waitUntilDone();

+ }

- document.body.offsetTop;

- location.href = "data:text/html,Test for rdar://problem/6937089 PASSED.";

+ document.body.offsetTop;

+ location.href = "data:text/html,<head><scr" + "ipt>function loaded() { if (window.testRunner) testRunner.notifyDone(); }</scr" + "ipt></head><body onload='loaded()'>Test for rdar://problem/6937089 PASSED.</body>";

+ }

</script>

+<body onload="loaded()">

+<p>

+ Test for <i><a href="rdar://problem/6937089">rdar://problem/6937089</a> Crashes at RenderWidget::destroy()</i>.

+</p>

+<p>

+ This test should not crash or cause an assertion failure.

+</p>

+<div id="target">

+ <embed type="application/x-webkit-test-netscape" ondestroy="destroyed()">

+</div>

+</body>

+</html>

« no previous file with comments | « LayoutTests/plugins/attach-during-destroy-expected.txt ('k') | LayoutTests/plugins/destroy-reentry-expected.txt » ('j') | no next file with comments »