Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3163008: Removed a command which resulted in a crash.... (Closed)

Created:
10 years, 4 months ago by Bons
Modified:
9 years, 5 months ago
CC:
chromium-reviews, John Grabowski, Paweł Hajdan Jr., pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Removed a command which resulted in a crash. Removed Unnescessary code and also refactored some. Added tests. Added example AppleScripts. original patch from shreyas. BUG=none TEST=updates some unit tests and adds some. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55946

Patch Set 1 #

Total comments: 1

Patch Set 2 : Typo fixed. #

Patch Set 3 : updated. #

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+218 lines, -42 lines) Patch
M chrome/browser/cocoa/applescript/bookmark_folder_applescript_unittest.mm View 1 2 3 4 2 chunks +17 lines, -22 lines 0 comments Download
M chrome/browser/cocoa/applescript/browsercrapplication+applescript.mm View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/browser/cocoa/applescript/browsercrapplication+applescript_test.mm View 1 2 3 4 1 chunk +107 lines, -0 lines 0 comments Download
A chrome/browser/cocoa/applescript/examples/app_info.applescript View 1 chunk +9 lines, -0 lines 0 comments Download
A chrome/browser/cocoa/applescript/examples/bookmark_current_tabs.applescript View 1 chunk +23 lines, -0 lines 0 comments Download
A chrome/browser/cocoa/applescript/examples/quit_app.applescript View 1 chunk +8 lines, -0 lines 0 comments Download
A chrome/browser/cocoa/applescript/examples/tab_navigation.applescript View 1 chunk +13 lines, -0 lines 0 comments Download
A chrome/browser/cocoa/applescript/examples/window_creation.applescript View 1 chunk +10 lines, -0 lines 0 comments Download
A chrome/browser/cocoa/applescript/examples/window_operations.applescript View 1 chunk +22 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/applescript/scripting.sdef View 1 2 3 4 3 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/cocoa/applescript/window_applescript.mm View 1 2 3 4 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/cocoa/applescript/window_applescript_test.mm View 1 2 3 4 3 chunks +2 lines, -8 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Bons
shreyas' original patch. If try bots look good I'm going to commit since it lgtm. ...
10 years, 4 months ago (2010-08-12 05:51:53 UTC) #1
pink (ping after 24hrs)
10 years, 4 months ago (2010-08-12 15:59:43 UTC) #2 
lgtm with one comment

http://codereview.chromium.org/3163008/diff/1/8
File chrome/browser/cocoa/applescript/bookmark_folder_applescript_unittest.mm
(right):

http://codereview.chromium.org/3163008/diff/1/8#newcode99
chrome/browser/cocoa/applescript/bookmark_folder_applescript_unittest.mm:99: N
typo?

Powered by Google App Engine
This is Rietveld 408576698