Removed a command which resulted in a crash....

chrome/browser/cocoa/applescript/bookmark_folder_applescript_unittest.mm

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/scoped_nsobject.h"
 #include "base/sys_string_conversions.h"
 #import "chrome/browser/cocoa/applescript/bookmark_applescript_utils_unittest.h"
 #import "chrome/browser/cocoa/applescript/bookmark_folder_applescript.h"
 #import "chrome/browser/cocoa/applescript/bookmark_item_applescript.h"
 #import "chrome/browser/cocoa/applescript/constants_applescript.h"
 #import "chrome/browser/cocoa/applescript/error_applescript.h"
 #include "googleurl/src/gurl.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #import "testing/gtest_mac.h"
 #include "testing/platform_test.h"
 
 typedef BookmarkAppleScriptTest BookmarkFolderAppleScriptTest;
 
 namespace {
 
 // Test all the bookmark folders within.
 TEST_F(BookmarkFolderAppleScriptTest, BookmarkFolders) {
   NSArray* bookmarkFolders = [bookmarkBar_.get() bookmarkFolders];
-  BookmarkFolderAppleScript* folder1 = [bookmarkFolders objectAtIndex:0];
-  BookmarkFolderAppleScript* folder2 = [bookmarkFolders objectAtIndex:1];
 
   EXPECT_EQ(2U, [bookmarkFolders count]);
 
-  EXPECT_NSEQ(@"f1", [folder1 title]);
-  EXPECT_NSEQ(@"f2", [folder2 title]);
-  EXPECT_EQ([folder1 container], bookmarkBar_.get());
-  EXPECT_EQ([folder2 container], bookmarkBar_.get());
-  EXPECT_NSEQ(AppleScript::kBookmarkFoldersProperty,
-              [folder1 containerProperty]);
-  EXPECT_NSEQ(AppleScript::kBookmarkFoldersProperty,
-              [folder2 containerProperty]);
+  EXPECT_NSEQ(@"f1", [[bookmarkFolders objectAtIndex:0] title]);
+  EXPECT_NSEQ(@"f2", [[bookmarkFolders objectAtIndex:1] title]);
+
+  for (BookmarkFolderAppleScript* bookmarkFolder in bookmarkFolders) {
+    EXPECT_EQ([bookmarkFolder container], bookmarkBar_.get());
+    EXPECT_NSEQ(AppleScript::kBookmarkFoldersProperty,
+                [bookmarkFolder containerProperty]);
+  }
 }
 
 // Insert a new bookmark folder.
 TEST_F(BookmarkFolderAppleScriptTest, InsertBookmarkFolder) {
   // Emulate what applescript would do when inserting a new bookmark folder.
   // Emulates a script like |set var to make new bookmark folder with
   // properties {title:"foo"}|.
   scoped_nsobject<BookmarkFolderAppleScript> bookmarkFolder(
       [[BookmarkFolderAppleScript alloc] init]);
   scoped_nsobject<NSNumber> var([[bookmarkFolder.get() uniqueID] copy]);
@@ skipping 36 matching lines @@
   for (unsigned int i = 0; i < folderCount; ++i) {
     EXPECT_EQ(folderCount - i, [[bookmarkBar_.get() bookmarkFolders] count]);
     EXPECT_EQ(itemCount, [[bookmarkBar_.get() bookmarkItems] count]);
     [bookmarkBar_.get() removeFromBookmarkFoldersAtIndex:0];
   }
 }
 
 // Test all the bookmark items within.
 TEST_F(BookmarkFolderAppleScriptTest, BookmarkItems) {
   NSArray* bookmarkItems = [bookmarkBar_.get() bookmarkItems];
-  BookmarkItemAppleScript* item1 = [bookmarkItems objectAtIndex:0];
-  BookmarkItemAppleScript* item2 = [bookmarkItems objectAtIndex:1];
-  BookmarkItemAppleScript* item3 = [bookmarkItems objectAtIndex:2];
 
   EXPECT_EQ(3U, [bookmarkItems count]);
 
-  EXPECT_NSEQ(@"a", [item1 title]);
-  EXPECT_NSEQ(@"d", [item2 title]);
-  EXPECT_NSEQ(@"h", [item3 title]);
-  EXPECT_EQ([item1 container], bookmarkBar_.get());
-  EXPECT_EQ([item2 container], bookmarkBar_.get());
-  EXPECT_EQ([item3 container], bookmarkBar_.get());
-  EXPECT_NSEQ(AppleScript::kBookmarkItemsProperty, [item1 containerProperty]);
-  EXPECT_NSEQ(AppleScript::kBookmarkItemsProperty, [item2 containerProperty]);
-  EXPECT_NSEQ(AppleScript::kBookmarkItemsProperty, [item3 containerProperty]);
+  EXPECT_NSEQ(@"a", [[bookmarkItems objectAtIndex:0] title]);
+  EXPECT_NSEQ(@"d", [[bookmarkItems objectAtIndex:1] title]);
+  EXPECT_NSEQ(@"h", [[bookmarkItems objectAtIndex:2] title]);
+
+  for (BookmarkItemAppleScript* bookmarkItem in bookmarkItems) {
+    EXPECT_EQ([bookmarkItem container], bookmarkBar_.get());
+    EXPECT_NSEQ(AppleScript::kBookmarkItemsProperty,
+                [bookmarkItem containerProperty]);
+  }
 }
 
 // Insert a new bookmark item.
 TEST_F(BookmarkFolderAppleScriptTest, InsertBookmarkItem) {
   // Emulate what applescript would do when inserting a new bookmark folder.
   // Emulates a script like |set var to make new bookmark item with
   // properties {title:"Google", URL:"http://google.com"}|.
   scoped_nsobject<BookmarkItemAppleScript> bookmarkItem(
       [[BookmarkItemAppleScript alloc] init]);
   scoped_nsobject<NSNumber> var([[bookmarkItem.get() uniqueID] copy]);
@@ skipping 66 matching lines @@
 
 // Set and get title.
 TEST_F(BookmarkFolderAppleScriptTest, GetAndSetTitle) {
   NSArray* bookmarkFolders = [bookmarkBar_.get() bookmarkFolders];
   BookmarkFolderAppleScript* folder1 = [bookmarkFolders objectAtIndex:0];
   [folder1 setTitle:@"Foo"];
   EXPECT_NSEQ(@"Foo", [folder1 title]);
 }
 
 }  // namespace