Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1204)

Unified Diff: pdf/pdfium/pdfium_page.cc

Issue 316233002: Fix some links in PDFs not working. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pdf/pdfium/pdfium_page.cc
===================================================================
--- pdf/pdfium/pdfium_page.cc (revision 275112)
+++ pdf/pdfium/pdfium_page.cc (working copy)
@@ -390,7 +390,7 @@
int url_length = FPDFLink_GetURL(links, i, NULL, 0);
if (url_length > 0) {
Lei Zhang 2014/06/05 22:26:21 This needs to be url_length > 1 because WriteInto(
jam 2014/06/06 01:17:51 actually, i looked more and the bug is in pdfium.
jam 2014/06/06 03:19:04 Done.
unsigned short* data =
- reinterpret_cast<unsigned short*>(WriteInto(&url, url_length + 1));
+ reinterpret_cast<unsigned short*>(WriteInto(&url, url_length));
FPDFLink_GetURL(links, i, data, url_length);
}
Link link;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698