Fix some links in PDFs not working.

pdf/pdfium/pdfium_page.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "pdf/pdfium/pdfium_page.h"
 
 #include <math.h>
 
 #include "base/logging.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 370 matching lines @@
 void PDFiumPage::CalculateLinks() {
   if (calculated_links_)
     return;
 
   calculated_links_ = true;
   FPDF_PAGELINK links = FPDFLink_LoadWebLinks(GetTextPage());
   int count = FPDFLink_CountWebLinks(links);
   for (int i = 0; i < count; ++i) {
     base::string16 url;
     int url_length = FPDFLink_GetURL(links, i, NULL, 0);
     if (url_length > 0) {

[Lei Zhang, 2014/06/05 22:26:21]

This needs to be url_length > 1 because WriteInto() says the length has to be at
least 2. It wouldn't make sense for a URL to be just the NULL terminator.

[jam, 2014/06/06 01:17:51]

actually, i looked more and the bug is in pdfium. i'll send a different cl for
that.

[jam, 2014/06/06 03:19:04]

Done.

       unsigned short* data =
-          reinterpret_cast<unsigned short*>(WriteInto(&url, url_length + 1));
+          reinterpret_cast<unsigned short*>(WriteInto(&url, url_length));
       FPDFLink_GetURL(links, i, data, url_length);
     }
     Link link;
     link.url = base::UTF16ToUTF8(url);
 
     // If the link cannot be converted to a pp::Var, then it is not possible to
     // pass it to JS. In this case, ignore the link like other PDF viewers.
     // See http://crbug.com/312882 for an example.
     pp::Var link_var(link.url);
     if (!link_var.is_string())
@@ skipping 65 matching lines @@
       new_left, new_top, new_right - new_left + 1, new_bottom - new_top + 1);
 }
 
 PDFiumPage::Link::Link() {
 }
 
 PDFiumPage::Link::~Link() {
 }
 
 }  // namespace chrome_pdf