Fix some links in PDFs not working.

Fix some links in PDFs not working.

We were adding an extra null into the string because FPDFLink_GetURL only gives the length without the null terminator.

BUG=pdfium:6
R=thestig@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275439

[jam, 2014-06-05 18:09:43]

I'm not sure how this worked before; something must have changed because PDFs
that worked before now don't.

[Lei Zhang, 2014-06-05 22:26:21]

https://codereview.chromium.org/316233002/diff/20001/pdf/pdfium/pdfium_page.cc
File pdf/pdfium/pdfium_page.cc (right):

https://codereview.chromium.org/316233002/diff/20001/pdf/pdfium/pdfium_page.c...
pdf/pdfium/pdfium_page.cc:391: if (url_length > 0) {
This needs to be url_length > 1 because WriteInto() says the length has to be at
least 2. It wouldn't make sense for a URL to be just the NULL terminator.

[jam, 2014-06-06 01:17:51]

https://codereview.chromium.org/316233002/diff/20001/pdf/pdfium/pdfium_page.cc
File pdf/pdfium/pdfium_page.cc (right):

https://codereview.chromium.org/316233002/diff/20001/pdf/pdfium/pdfium_page.c...
pdf/pdfium/pdfium_page.cc:391: if (url_length > 0) {
On 2014/06/05 22:26:21, Lei Zhang wrote:
> This needs to be url_length > 1 because WriteInto() says the length has to be
at
> least 2. It wouldn't make sense for a URL to be just the NULL terminator.

actually, i looked more and the bug is in pdfium. i'll send a different cl for
that.

[Lei Zhang, 2014-06-06 01:29:07]

On 2014/06/06 01:17:51, jam wrote:
> https://codereview.chromium.org/316233002/diff/20001/pdf/pdfium/pdfium_page.cc
> File pdf/pdfium/pdfium_page.cc (right):
> 
>
https://codereview.chromium.org/316233002/diff/20001/pdf/pdfium/pdfium_page.c...
> pdf/pdfium/pdfium_page.cc:391: if (url_length > 0) {
> On 2014/06/05 22:26:21, Lei Zhang wrote:
> > This needs to be url_length > 1 because WriteInto() says the length has to
be
> at
> > least 2. It wouldn't make sense for a URL to be just the NULL terminator.
> 
> actually, i looked more and the bug is in pdfium. i'll send a different cl for
> that.

We had some issues a few months ago with URLs with NUL characters in them.
Perhaps I was too aggressive when filtering them out?

[jam, 2014-06-06 03:19:05]

https://codereview.chromium.org/316233002/diff/20001/pdf/pdfium/pdfium_page.cc
File pdf/pdfium/pdfium_page.cc (right):

https://codereview.chromium.org/316233002/diff/20001/pdf/pdfium/pdfium_page.c...
pdf/pdfium/pdfium_page.cc:391: if (url_length > 0) {
On 2014/06/06 01:17:51, jam wrote:
> On 2014/06/05 22:26:21, Lei Zhang wrote:
> > This needs to be url_length > 1 because WriteInto() says the length has to
be
> at
> > least 2. It wouldn't make sense for a URL to be just the NULL terminator.
> 
> actually, i looked more and the bug is in pdfium. i'll send a different cl for
> that.

Done.

[Lei Zhang, 2014-06-06 03:40:28]

lgtm