Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 316173008: IDL build: factor out global objects action into a GYP template (Closed)

Created:
6 years, 6 months ago by Nils Barth (inactive)
Modified:
6 years, 6 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium, Nico, brettw, c.shu
Visibility:
Public.

Description

IDL build: factor out global objects action into a GYP template First (simple) step in factoring out redundant GYP actions into templates. Also moves the 'write_file_only_if_changed' flag to scripts, as that's where it's used, which allows more simplification. R=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175848

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -71 lines) Patch
M Source/bindings/bindings.gypi View 1 chunk +0 lines, -14 lines 0 comments Download
M Source/bindings/core/core.gypi View 1 chunk +0 lines, -1 line 1 comment Download
M Source/bindings/core/generated.gyp View 2 chunks +5 lines, -27 lines 1 comment Download
M Source/bindings/modules/generated.gyp View 2 chunks +8 lines, -27 lines 0 comments Download
M Source/bindings/modules/modules.gypi View 1 chunk +0 lines, -1 line 0 comments Download
A Source/bindings/scripts/global_objects.gypi View 1 chunk +64 lines, -0 lines 0 comments Download
M Source/bindings/scripts/scripts.gypi View 1 chunk +14 lines, -0 lines 0 comments Download
M Source/core/core_generated.gyp View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 41 (0 generated)
Nils Barth (inactive)
Factoring out, per Nico's suggestion. https://codereview.chromium.org/316173008/diff/1/Source/bindings/core/core.gypi File Source/bindings/core/core.gypi (left): https://codereview.chromium.org/316173008/diff/1/Source/bindings/core/core.gypi#oldcode7 Source/bindings/core/core.gypi:7: '../bindings.gypi', Componentization fix! https://codereview.chromium.org/316173008/diff/1/Source/bindings/core/generated.gyp ...
6 years, 6 months ago (2014-06-06 05:28:43 UTC) #1
haraken
LGTM
6 years, 6 months ago (2014-06-06 05:35:19 UTC) #2
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 6 months ago (2014-06-06 05:41:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/316173008/1
6 years, 6 months ago (2014-06-06 05:42:01 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 6 months ago (2014-06-06 06:30:53 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 06:31:15 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/14710)
6 years, 6 months ago (2014-06-06 06:31:16 UTC) #7
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 6 months ago (2014-06-06 07:21:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/316173008/1
6 years, 6 months ago (2014-06-06 07:22:17 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-06 07:27:26 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 07:28:36 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/8347) mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/10546)
6 years, 6 months ago (2014-06-06 07:28:37 UTC) #12
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 6 months ago (2014-06-06 07:37:05 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/316173008/1
6 years, 6 months ago (2014-06-06 07:37:19 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-06 08:11:18 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 08:12:32 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/8354)
6 years, 6 months ago (2014-06-06 08:12:33 UTC) #17
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 6 months ago (2014-06-06 09:24:54 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/316173008/1
6 years, 6 months ago (2014-06-06 09:25:48 UTC) #19
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-06 09:54:10 UTC) #20
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 09:55:32 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/8376)
6 years, 6 months ago (2014-06-06 09:55:33 UTC) #22
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 6 months ago (2014-06-06 11:11:11 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/316173008/1
6 years, 6 months ago (2014-06-06 11:12:08 UTC) #24
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-06 11:14:54 UTC) #25
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 11:16:14 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/8383)
6 years, 6 months ago (2014-06-06 11:16:15 UTC) #27
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 6 months ago (2014-06-06 11:43:03 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/316173008/1
6 years, 6 months ago (2014-06-06 11:44:05 UTC) #29
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-06 11:46:40 UTC) #30
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 11:48:11 UTC) #31
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/8388)
6 years, 6 months ago (2014-06-06 11:48:12 UTC) #32
Nils Barth (inactive)
On 2014/06/06 11:48:12, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 6 months ago (2014-06-06 11:54:56 UTC) #33
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 6 months ago (2014-06-06 12:21:25 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/316173008/1
6 years, 6 months ago (2014-06-06 12:22:27 UTC) #35
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-06 12:25:26 UTC) #36
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 12:26:50 UTC) #37
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/8394)
6 years, 6 months ago (2014-06-06 12:26:51 UTC) #38
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 6 months ago (2014-06-10 01:31:21 UTC) #39
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/316173008/1
6 years, 6 months ago (2014-06-10 01:32:07 UTC) #40
commit-bot: I haz the power
6 years, 6 months ago (2014-06-10 02:38:36 UTC) #41
Message was sent while issue was closed.
Change committed as 175848

Powered by Google App Engine
This is Rietveld 408576698