Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Unified Diff: Source/bindings/scripts/scripts.gypi

Issue 316173008: IDL build: factor out global objects action into a GYP template (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/scripts/scripts.gypi
diff --git a/Source/bindings/scripts/scripts.gypi b/Source/bindings/scripts/scripts.gypi
index ab5445e15460096e06474809edd3ff6ba1bd22ba..9bf033d7eee635bc7f20f112a6acb4efc8e07108 100644
--- a/Source/bindings/scripts/scripts.gypi
+++ b/Source/bindings/scripts/scripts.gypi
@@ -41,5 +41,19 @@
'v8_types.py',
'v8_utilities.py',
],
+
+ 'conditions': [
+ # These scripts can skip writing generated files if they are identical
+ # to the already existing files, which avoids further build steps, like
+ # recompilation. However, a dependency (earlier build step) having a
+ # newer timestamp than an output (later build step) confuses some build
+ # systems, so only use this on ninja, which explicitly supports this use
+ # case (gyp turns all actions into ninja restat rules).
+ ['"<(GENERATOR)"=="ninja"', {
+ 'write_file_only_if_changed': '1',
+ }, {
+ 'write_file_only_if_changed': '0',
+ }],
+ ],
},
}

Powered by Google App Engine
This is Rietveld 408576698