Issue 316019: Increase visual spacing between browser action buttons to 5px.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 316019: Increase visual spacing between browser action buttons to 5px. (Closed)

Created:
11 years, 2 months ago by rafaelw

Modified:
9 years, 7 months ago

Reviewers:
Aaron Boodman, Evan Stade

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Increase visual spacing between browser action buttons to 5px. BUG=25444 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29988

Patch Set 3 : cr change #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -2 lines)			Patch
	M	chrome/browser/gtk/browser_actions_toolbar_gtk.cc	View	1 2	2 chunks	+6 lines, -1 line	0 comments	Download
	M	chrome/browser/views/browser_actions_container.cc	View		2 chunks	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

http://codereview.chromium.org/316019/diff/1003/2001 File chrome/browser/gtk/browser_actions_toolbar_gtk.cc (right): http://codereview.chromium.org/316019/diff/1003/2001#newcode172 Line 172: hbox_(gtk_hbox_new(0, FALSE)) { this should be gtk_hbox_new(FALSE, kBrowserActionButtonPadding) ...

11 years, 2 months ago (2009-10-22 23:13:11 UTC) #3

rafaelw

11 years, 2 months ago (2009-10-22 23:38:43 UTC) #4

lgtm

Expand Messages | Collapse Messages

Issue 316019: Increase visual spacing between browser action buttons to 5px. (Closed)

Description

Patch Set 1 #

Patch Set 2 : pre cr #

Patch Set 3 : cr change #

Messages