Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1092)

Unified Diff: chrome/browser/gtk/browser_actions_toolbar_gtk.cc

Issue 316019: Increase visual spacing between browser action buttons to 5px. (Closed)
Patch Set: cr change Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/views/browser_actions_container.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/gtk/browser_actions_toolbar_gtk.cc
diff --git a/chrome/browser/gtk/browser_actions_toolbar_gtk.cc b/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
index 53e27e975539a4c35ebb06f6a41eeebd57e25c9e..eefba1b3a8d975c62a340238399e163204f6b62c 100644
--- a/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
+++ b/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
@@ -26,6 +26,11 @@
// The size of each button on the toolbar.
static const int kButtonSize = 29;
+// The padding between browser action buttons. Visually, the actual number of
+// "empty" (non-drawing) pixels is this value + 2 when adjacent browser icons
+// use their maximum allowed size.
+static const int kBrowserActionButtonPadding = 3;
+
class BrowserActionButton : public NotificationObserver,
public ImageLoadingTracker::Observer {
public:
@@ -164,7 +169,7 @@ class BrowserActionButton : public NotificationObserver,
BrowserActionsToolbarGtk::BrowserActionsToolbarGtk(Browser* browser)
: browser_(browser),
profile_(browser->profile()),
- hbox_(gtk_hbox_new(0, FALSE)) {
+ hbox_(gtk_hbox_new(FALSE, kBrowserActionButtonPadding)) {
ExtensionsService* extension_service = profile_->GetExtensionsService();
registrar_.Add(this, NotificationType::EXTENSION_LOADED,
Source<ExtensionsService>(extension_service));
« no previous file with comments | « no previous file | chrome/browser/views/browser_actions_container.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698