Fix crash with page actions without icons

Page actions that don't specify an icon (ie.
have a spelling error in the manifest, such as
icon instead of icons/default_icon) caused a
crash when they try to display their icon.

We now check when the extension tries to enable
the page action whether there are any icons to
display. If not, we don't proceed and log an
error to the console.

BUG=25562
TEST=Covered by browser test.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29861

[Matt Perry, 2009-10-22 22:41:06]

linux too!

http://codereview.chromium.org/316018/diff/1/7
File chrome/browser/extensions/extension_page_actions_module.cc (right):

http://codereview.chromium.org/316018/diff/1/7#newcode60
Line 60: if (icon_id < 0) {
the SetIcon method below does this check:
(icon_index < 0 ||
 static_cast<size_t>(icon_index) >= page_action_->icon_paths().size())

If we change this to do that check, we won't need the empty() check below.

http://codereview.chromium.org/316018/diff/1/8
File chrome/browser/views/location_bar_view.cc (right):

http://codereview.chromium.org/316018/diff/1/8#newcode716
Line 716: int index = 0;
nit: i'd rename this to view_index or something, to differentiate it from 'i'

http://codereview.chromium.org/316018/diff/10/1014#newcode704
Line 704: for (size_t i = 0; i < page_actions.size(); ++i) {
here's a suggestion to make this simpler:
 if (paths empty)
   page_actions.erase(page_actions.begin() + i);
 else
   i++;

then you don't have to make the rest of the changes.

[Finnur, 2009-10-22 23:19:02]

Uploaded and sprinkled some Linux love onto the patch.

[Matt Perry, 2009-10-22 23:22:40]

lgtm