chrome/test/data/extensions/browsertest/crash_25562/background.html - Issue 316018: Fix crash with page actions without icons

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/extensions/browsertest/crash_25562/background.html

Issue 316018: Fix crash with page actions without icons (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 11 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <html>

	2 <script>

	3 // The Page Action ID.

	4 var pageActionId = "TestId";

	5

	6 // The window this Page Action is associated with.

	7 var windowId = -1;

	8

	9 // The TabId this Page Action is associated with.

	10 var tabId = -1;

	11

	12 // The URL of the page on build.chromium.org.

	13 var pageUrl = "";

	14

	15 chrome.self.onConnect.addListener(function(port) {

	16 windowId = port.tab.windowId;

	17 tabId = port.tab.id;

	18 pageUrl = port.tab.url;

	19

	20 port.onMessage.addListener(function(mybool) {

	21 // Let Chrome know that the PageAction needs to be enabled for this tabId

	22 // and for the url of this page.

	23 chrome.pageActions.enableForTab(pageActionId,

	24 {tabId: tabId, url: pageUrl});

	25 });

	26 });

	27 </script>

	28 </html>

OLD	NEW