Support using a mock SDK with the resolver in code-transformers, and switch

Support using a mock SDK with the resolver in code-transformers, and switch
polymer to do so.

This makes TodoMVC compile in 2.8s instead of 4.8s on my machine.

R=blois@google.com, jmesserly@google.com

Committed: https://code.google.com/p/dart/source/detail?r=37026

[Siggi Cherem (dart-lang), 2014-06-04 02:26:59]

https://codereview.chromium.org/315813003/diff/40001/pkg/code_transformers/li...
File pkg/code_transformers/lib/src/dart_sdk.dart (right):

https://codereview.chromium.org/315813003/diff/40001/pkg/code_transformers/li...
pkg/code_transformers/lib/src/dart_sdk.dart:58: abstract class
UriAnnotatedSource extends Source {
this interface is new (common to DartSourceProxy and MockSdkSource)

https://codereview.chromium.org/315813003/diff/40001/pkg/code_transformers/li...
pkg/code_transformers/lib/src/dart_sdk.dart:64: class DirectoryBasedDartSdkProxy
extends DirectoryBasedDartSdk {
this is the same code as before, but I moved it here to put all the SDK
wrapping/mocking stuff together.

https://codereview.chromium.org/315813003/diff/40001/pkg/code_transformers/li...
pkg/code_transformers/lib/src/dart_sdk.dart:142: class MockDartSdk implements
DartSdk {
here is where the new stuff begins

https://codereview.chromium.org/315813003/diff/40001/pkg/code_transformers/li...
File pkg/code_transformers/lib/src/resolver_impl.dart (right):

https://codereview.chromium.org/315813003/diff/40001/pkg/code_transformers/li...
pkg/code_transformers/lib/src/resolver_impl.dart:64: sdk.context.analysisOptions
= options;
should we do this, or let these options be specified once only?

[Siggi Cherem (dart-lang), 2014-06-04 02:28:33]

I'm not sure how brittle this is going to be. I'm playing around with some
examples and tests.

[Jennifer Messerly, 2014-06-04 04:17:39]

lgtm

https://codereview.chromium.org/315813003/diff/40001/pkg/polymer/lib/src/buil...
File pkg/polymer/lib/src/build/script_compactor.dart (right):

https://codereview.chromium.org/315813003/diff/40001/pkg/polymer/lib/src/buil...
pkg/polymer/lib/src/build/script_compactor.dart:53: 'dart:core': '''
just curious, how was this list chosen?

[blois, 2014-06-04 16:31:21]

https://codereview.chromium.org/315813003/diff/40001/pkg/code_transformers/li...
File pkg/code_transformers/lib/src/dart_sdk.dart (right):

https://codereview.chromium.org/315813003/diff/40001/pkg/code_transformers/li...
pkg/code_transformers/lib/src/dart_sdk.dart:184: final int modificationStamp =
new DateTime.now().millisecondsSinceEpoch;
Can just do '1' or something as well.

https://codereview.chromium.org/315813003/diff/40001/pkg/code_transformers/li...
File pkg/code_transformers/lib/src/resolvers.dart (right):

https://codereview.chromium.org/315813003/diff/40001/pkg/code_transformers/li...
pkg/code_transformers/lib/src/resolvers.dart:33: factory
Resolvers.fromSdkDirectory(dartSdkDirectory) {
Can these two constructors be swapped to avoid a breaking change?

[Siggi Cherem (dart-lang), 2014-06-04 21:25:18]

Thanks

https://codereview.chromium.org/315813003/diff/40001/pkg/code_transformers/li...
File pkg/code_transformers/lib/src/dart_sdk.dart (right):

https://codereview.chromium.org/315813003/diff/40001/pkg/code_transformers/li...
pkg/code_transformers/lib/src/dart_sdk.dart:184: final int modificationStamp =
new DateTime.now().millisecondsSinceEpoch;
On 2014/06/04 16:31:22, blois wrote:
> Can just do '1' or something as well.

Done.

https://codereview.chromium.org/315813003/diff/40001/pkg/code_transformers/li...
File pkg/code_transformers/lib/src/resolvers.dart (right):

https://codereview.chromium.org/315813003/diff/40001/pkg/code_transformers/li...
pkg/code_transformers/lib/src/resolvers.dart:33: factory
Resolvers.fromSdkDirectory(dartSdkDirectory) {
On 2014/06/04 16:31:22, blois wrote:
> Can these two constructors be swapped to avoid a breaking change?

Good idea, done.

https://codereview.chromium.org/315813003/diff/40001/pkg/polymer/lib/src/buil...
File pkg/polymer/lib/src/build/script_compactor.dart (right):

https://codereview.chromium.org/315813003/diff/40001/pkg/polymer/lib/src/buil...
pkg/polymer/lib/src/build/script_compactor.dart:53: 'dart:core': '''
On 2014/06/04 04:17:39, John Messerly wrote:
> just curious, how was this list chosen?

The list of libraries was a bit adhoc, I was adding as needed. I changed to now
use a minimal list and return an empty library if it wasn't specified.

As for the types in Core, I added a comment where this comes from. Basically:
 - types we rely on in polymer (both in deserialize & in the smoke queries)
 - types that the analyzer needs to run correctly.

[Siggi Cherem (dart-lang), 2014-06-05 00:54:34]

BTW, I did a small change to not throw when a library is missing, but show a
warning if the user of Resolvers requests it. So I'll wait until you take
another look before submitting.

[blois, 2014-06-05 01:11:51]

lgtm

[Siggi Cherem (dart-lang), 2014-06-05 01:48:04]

Committed patchset #2 manually as r37026 (presubmit successful).